Allow incompletely specified Time Formats (#8816)

zeripath · techknowlogick · commit baae90e163d7 · 2019-12-08T16:25:00.000-05:00
* Allow incompletely specified time formats

* Adjust error reporting slightly

* Update setting.go
diff --git a/modules/setting/setting.go b/modules/setting/setting.go
@@ -835,7 +835,8 @@ func NewContext() {
 			TimeFormat = timeFormatKey
 			TestTimeFormat, _ := time.Parse(TimeFormat, TimeFormat)
 			if TestTimeFormat.Format(time.RFC3339) != "2006-01-02T15:04:05Z" {
-				log.Fatal("Can't create time properly, please check your time format has 2006, 01, 02, 15, 04 and 05")
+				log.Warn("Provided TimeFormat: %s does not create a fully specified date and time.", TimeFormat)
+				log.Warn("In order to display dates and times correctly please check your time format has 2006, 01, 02, 15, 04 and 05")
 			}
 			log.Trace("Custom TimeFormat: %s", TimeFormat)
 		}

Original file line number	Diff line number	Diff line change
`@@ -835,7 +835,8 @@ func NewContext() {`
`835`	`835`	`TimeFormat = timeFormatKey`
`836`	`836`	`TestTimeFormat, _ := time.Parse(TimeFormat, TimeFormat)`
`837`	`837`	`if TestTimeFormat.Format(time.RFC3339) != "2006-01-02T15:04:05Z" {`
`838`		`- log.Fatal("Can't create time properly, please check your time format has 2006, 01, 02, 15, 04 and 05")`
	`838`	`+ log.Warn("Provided TimeFormat: %s does not create a fully specified date and time.", TimeFormat)`
	`839`	`+ log.Warn("In order to display dates and times correctly please check your time format has 2006, 01, 02, 15, 04 and 05")`
`839`	`840`	`}`
`840`	`841`	`log.Trace("Custom TimeFormat: %s", TimeFormat)`
`841`	`842`	`}`