Skip to content

Commit bd66fa5

Browse files
yp05327yardenshoham
yp05327
and
yardenshoham
authored
Rename repo.GetOwner to repo.LoadOwner (#22967)
Fixes #22963 --------- Co-authored-by: Yarden Shoham <[email protected]>
1 parent 007d181 commit bd66fa5

33 files changed

+68
-68
lines changed

‎models/activities/action.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ func NotifyWatchers(ctx context.Context, actions ...*Action) error {
534534
repo = act.Repo
535535

536536
// check repo owner exist.
537-
if err := act.Repo.GetOwner(ctx); err != nil {
537+
if err := act.Repo.LoadOwner(ctx); err != nil {
538538
return fmt.Errorf("can't get repo owner: %w", err)
539539
}
540540
} else if act.Repo == nil {

‎models/git/protected_branch.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -314,8 +314,8 @@ type WhitelistOptions struct {
314314
// This function also performs check if whitelist user and team's IDs have been changed
315315
// to avoid unnecessary whitelist delete and regenerate.
316316
func UpdateProtectBranch(ctx context.Context, repo *repo_model.Repository, protectBranch *ProtectedBranch, opts WhitelistOptions) (err error) {
317-
if err = repo.GetOwner(ctx); err != nil {
318-
return fmt.Errorf("GetOwner: %v", err)
317+
if err = repo.LoadOwner(ctx); err != nil {
318+
return fmt.Errorf("LoadOwner: %v", err)
319319
}
320320

321321
whitelist, err := updateUserWhitelist(ctx, repo, protectBranch.WhitelistUserIDs, opts.UserIDs)

‎models/issues/comment.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ func (c *Comment) LoadAssigneeUserAndTeam() error {
620620
return err
621621
}
622622

623-
if err = c.Issue.Repo.GetOwner(db.DefaultContext); err != nil {
623+
if err = c.Issue.Repo.LoadOwner(db.DefaultContext); err != nil {
624624
return err
625625
}
626626

@@ -824,7 +824,7 @@ func CreateComment(ctx context.Context, opts *CreateCommentOptions) (_ *Comment,
824824
return nil, err
825825
}
826826

827-
if err = opts.Repo.GetOwner(ctx); err != nil {
827+
if err = opts.Repo.LoadOwner(ctx); err != nil {
828828
return nil, err
829829
}
830830

‎models/issues/issue.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -2099,7 +2099,7 @@ func ResolveIssueMentionsByVisibility(ctx context.Context, issue *Issue, doer *u
20992099
resolved := make(map[string]bool, 10)
21002100
var mentionTeams []string
21012101

2102-
if err := issue.Repo.GetOwner(ctx); err != nil {
2102+
if err := issue.Repo.LoadOwner(ctx); err != nil {
21032103
return nil, err
21042104
}
21052105

‎models/issues/pull.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ func (pr *PullRequest) SetMerged(ctx context.Context) (bool, error) {
498498
return false, err
499499
}
500500

501-
if err := pr.Issue.Repo.GetOwner(ctx); err != nil {
501+
if err := pr.Issue.Repo.LoadOwner(ctx); err != nil {
502502
return false, err
503503
}
504504

‎models/perm/access/access.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ func updateUserAccess(accessMap map[int64]*userAccess, user *user_model.User, mo
8585
// FIXME: do cross-comparison so reduce deletions and additions to the minimum?
8686
func refreshAccesses(ctx context.Context, repo *repo_model.Repository, accessMap map[int64]*userAccess) (err error) {
8787
minMode := perm.AccessModeRead
88-
if err := repo.GetOwner(ctx); err != nil {
89-
return fmt.Errorf("GetOwner: %w", err)
88+
if err := repo.LoadOwner(ctx); err != nil {
89+
return fmt.Errorf("LoadOwner: %w", err)
9090
}
9191

9292
// If the repo isn't private and isn't owned by a organization,
@@ -143,7 +143,7 @@ func refreshCollaboratorAccesses(ctx context.Context, repoID int64, accessMap ma
143143
func RecalculateTeamAccesses(ctx context.Context, repo *repo_model.Repository, ignTeamID int64) (err error) {
144144
accessMap := make(map[int64]*userAccess, 20)
145145

146-
if err = repo.GetOwner(ctx); err != nil {
146+
if err = repo.LoadOwner(ctx); err != nil {
147147
return err
148148
} else if !repo.Owner.IsOrganization() {
149149
return fmt.Errorf("owner is not an organization: %d", repo.OwnerID)
@@ -199,7 +199,7 @@ func RecalculateUserAccess(ctx context.Context, repo *repo_model.Repository, uid
199199
accessMode = collaborator.Mode
200200
}
201201

202-
if err = repo.GetOwner(ctx); err != nil {
202+
if err = repo.LoadOwner(ctx); err != nil {
203203
return err
204204
} else if repo.Owner.IsOrganization() {
205205
var teams []organization.Team

‎models/perm/access/access_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func TestRepository_RecalculateAccesses(t *testing.T) {
9797
// test with organization repo
9898
assert.NoError(t, unittest.PrepareTestDatabase())
9999
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})
100-
assert.NoError(t, repo1.GetOwner(db.DefaultContext))
100+
assert.NoError(t, repo1.LoadOwner(db.DefaultContext))
101101

102102
_, err := db.GetEngine(db.DefaultContext).Delete(&repo_model.Collaboration{UserID: 2, RepoID: 3})
103103
assert.NoError(t, err)
@@ -114,7 +114,7 @@ func TestRepository_RecalculateAccesses2(t *testing.T) {
114114
// test with non-organization repo
115115
assert.NoError(t, unittest.PrepareTestDatabase())
116116
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 4})
117-
assert.NoError(t, repo1.GetOwner(db.DefaultContext))
117+
assert.NoError(t, repo1.LoadOwner(db.DefaultContext))
118118

119119
_, err := db.GetEngine(db.DefaultContext).Delete(&repo_model.Collaboration{UserID: 4, RepoID: 4})
120120
assert.NoError(t, err)

‎models/perm/access/repo_permission.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ func GetUserRepoPermission(ctx context.Context, repo *repo_model.Repository, use
175175
}
176176
}
177177

178-
if err = repo.GetOwner(ctx); err != nil {
178+
if err = repo.LoadOwner(ctx); err != nil {
179179
return
180180
}
181181

@@ -210,7 +210,7 @@ func GetUserRepoPermission(ctx context.Context, repo *repo_model.Repository, use
210210
return
211211
}
212212

213-
if err = repo.GetOwner(ctx); err != nil {
213+
if err = repo.LoadOwner(ctx); err != nil {
214214
return
215215
}
216216
if !repo.Owner.IsOrganization() {
@@ -281,7 +281,7 @@ func IsUserRealRepoAdmin(repo *repo_model.Repository, user *user_model.User) (bo
281281
return true, nil
282282
}
283283

284-
if err := repo.GetOwner(db.DefaultContext); err != nil {
284+
if err := repo.LoadOwner(db.DefaultContext); err != nil {
285285
return false, err
286286
}
287287

@@ -378,7 +378,7 @@ func HasAccess(ctx context.Context, userID int64, repo *repo_model.Repository) (
378378

379379
// getUsersWithAccessMode returns users that have at least given access mode to the repository.
380380
func getUsersWithAccessMode(ctx context.Context, repo *repo_model.Repository, mode perm_model.AccessMode) (_ []*user_model.User, err error) {
381-
if err = repo.GetOwner(ctx); err != nil {
381+
if err = repo.LoadOwner(ctx); err != nil {
382382
return nil, err
383383
}
384384

‎models/repo/repo.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ func (repo *Repository) AfterLoad() {
237237
// LoadAttributes loads attributes of the repository.
238238
func (repo *Repository) LoadAttributes(ctx context.Context) error {
239239
// Load owner
240-
if err := repo.GetOwner(ctx); err != nil {
240+
if err := repo.LoadOwner(ctx); err != nil {
241241
return fmt.Errorf("load owner: %w", err)
242242
}
243243

@@ -373,8 +373,8 @@ func (repo *Repository) GetUnit(ctx context.Context, tp unit.Type) (*RepoUnit, e
373373
return nil, ErrUnitTypeNotExist{tp}
374374
}
375375

376-
// GetOwner returns the repository owner
377-
func (repo *Repository) GetOwner(ctx context.Context) (err error) {
376+
// LoadOwner loads owner user
377+
func (repo *Repository) LoadOwner(ctx context.Context) (err error) {
378378
if repo.Owner != nil {
379379
return nil
380380
}
@@ -388,7 +388,7 @@ func (repo *Repository) GetOwner(ctx context.Context) (err error) {
388388
// It creates a fake object that contains error details
389389
// when error occurs.
390390
func (repo *Repository) MustOwner(ctx context.Context) *user_model.User {
391-
if err := repo.GetOwner(ctx); err != nil {
391+
if err := repo.LoadOwner(ctx); err != nil {
392392
return &user_model.User{
393393
Name: "error",
394394
FullName: err.Error(),

‎models/repo/update.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ func ChangeRepositoryName(doer *user_model.User, repo *Repository, newRepoName s
143143
return err
144144
}
145145

146-
if err := repo.GetOwner(db.DefaultContext); err != nil {
146+
if err := repo.LoadOwner(db.DefaultContext); err != nil {
147147
return err
148148
}
149149

‎models/repo/user_repo.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ func GetWatchedRepos(ctx context.Context, userID int64, private bool, listOption
6161
// GetRepoAssignees returns all users that have write access and can be assigned to issues
6262
// of the repository,
6363
func GetRepoAssignees(ctx context.Context, repo *Repository) (_ []*user_model.User, err error) {
64-
if err = repo.GetOwner(ctx); err != nil {
64+
if err = repo.LoadOwner(ctx); err != nil {
6565
return nil, err
6666
}
6767

@@ -111,7 +111,7 @@ func GetRepoAssignees(ctx context.Context, repo *Repository) (_ []*user_model.Us
111111
// TODO: may be we should have a busy choice for users to block review request to them.
112112
func GetReviewers(ctx context.Context, repo *Repository, doerID, posterID int64) ([]*user_model.User, error) {
113113
// Get the owner of the repository - this often already pre-cached and if so saves complexity for the following queries
114-
if err := repo.GetOwner(ctx); err != nil {
114+
if err := repo.LoadOwner(ctx); err != nil {
115115
return nil, err
116116
}
117117

‎models/repo_collaboration_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func TestRepository_DeleteCollaboration(t *testing.T) {
1717
assert.NoError(t, unittest.PrepareTestDatabase())
1818

1919
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 4})
20-
assert.NoError(t, repo.GetOwner(db.DefaultContext))
20+
assert.NoError(t, repo.LoadOwner(db.DefaultContext))
2121
assert.NoError(t, DeleteCollaboration(repo, 4))
2222
unittest.AssertNotExistsBean(t, &repo_model.Collaboration{RepoID: repo.ID, UserID: 4})
2323

‎modules/context/repo.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -273,8 +273,8 @@ func RetrieveBaseRepo(ctx *Context, repo *repo_model.Repository) {
273273
}
274274
ctx.ServerError("GetBaseRepo", err)
275275
return
276-
} else if err = repo.BaseRepo.GetOwner(ctx); err != nil {
277-
ctx.ServerError("BaseRepo.GetOwner", err)
276+
} else if err = repo.BaseRepo.LoadOwner(ctx); err != nil {
277+
ctx.ServerError("BaseRepo.LoadOwner", err)
278278
return
279279
}
280280
}
@@ -290,8 +290,8 @@ func RetrieveTemplateRepo(ctx *Context, repo *repo_model.Repository) {
290290
}
291291
ctx.ServerError("GetTemplateRepo", err)
292292
return
293-
} else if err = templateRepo.GetOwner(ctx); err != nil {
294-
ctx.ServerError("TemplateRepo.GetOwner", err)
293+
} else if err = templateRepo.LoadOwner(ctx); err != nil {
294+
ctx.ServerError("TemplateRepo.LoadOwner", err)
295295
return
296296
}
297297

@@ -356,8 +356,8 @@ func RedirectToRepo(ctx *Context, redirectRepoID int64) {
356356

357357
func repoAssignment(ctx *Context, repo *repo_model.Repository) {
358358
var err error
359-
if err = repo.GetOwner(ctx); err != nil {
360-
ctx.ServerError("GetOwner", err)
359+
if err = repo.LoadOwner(ctx); err != nil {
360+
ctx.ServerError("LoadOwner", err)
361361
return
362362
}
363363

‎modules/doctor/misc.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ func checkDaemonExport(ctx context.Context, logger log.Logger, autofix bool) err
141141
if owner, has := cache.Get(repo.OwnerID); has {
142142
repo.Owner = owner.(*user_model.User)
143143
} else {
144-
if err := repo.GetOwner(ctx); err != nil {
144+
if err := repo.LoadOwner(ctx); err != nil {
145145
return err
146146
}
147147
cache.Add(repo.OwnerID, repo.Owner)

‎modules/repository/collaborator_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func TestRepository_AddCollaborator(t *testing.T) {
2323

2424
testSuccess := func(repoID, userID int64) {
2525
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: repoID})
26-
assert.NoError(t, repo.GetOwner(db.DefaultContext))
26+
assert.NoError(t, repo.LoadOwner(db.DefaultContext))
2727
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: userID})
2828
assert.NoError(t, AddCollaborator(db.DefaultContext, repo, user))
2929
unittest.CheckConsistencyFor(t, &repo_model.Repository{ID: repoID}, &user_model.User{ID: userID})

‎modules/repository/create.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ func UpdateRepoSize(ctx context.Context, repo *repo_model.Repository) error {
335335

336336
// CheckDaemonExportOK creates/removes git-daemon-export-ok for git-daemon...
337337
func CheckDaemonExportOK(ctx context.Context, repo *repo_model.Repository) error {
338-
if err := repo.GetOwner(ctx); err != nil {
338+
if err := repo.LoadOwner(ctx); err != nil {
339339
return err
340340
}
341341

@@ -379,8 +379,8 @@ func UpdateRepository(ctx context.Context, repo *repo_model.Repository, visibili
379379
}
380380

381381
if visibilityChanged {
382-
if err = repo.GetOwner(ctx); err != nil {
383-
return fmt.Errorf("getOwner: %w", err)
382+
if err = repo.LoadOwner(ctx); err != nil {
383+
return fmt.Errorf("LoadOwner: %w", err)
384384
}
385385
if repo.Owner.IsOrganization() {
386386
// Organization repository need to recalculate access table when visibility is changed.

‎modules/repository/delete.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ func CanUserDelete(repo *repo_model.Repository, user *user_model.User) (bool, er
1616
return true, nil
1717
}
1818

19-
if err := repo.GetOwner(db.DefaultContext); err != nil {
19+
if err := repo.LoadOwner(db.DefaultContext); err != nil {
2020
return false, err
2121
}
2222

‎modules/test/context_tests.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func LoadUser(t *testing.T, ctx *context.Context, userID int64) {
8686
// LoadGitRepo load a git repo into a test context. Requires that ctx.Repo has
8787
// already been populated.
8888
func LoadGitRepo(t *testing.T, ctx *context.Context) {
89-
assert.NoError(t, ctx.Repo.Repository.GetOwner(ctx))
89+
assert.NoError(t, ctx.Repo.Repository.LoadOwner(ctx))
9090
var err error
9191
ctx.Repo.GitRepo, err = git.OpenRepository(ctx, ctx.Repo.Repository.RepoPath())
9292
assert.NoError(t, err)

‎routers/api/v1/repo/repo.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ func Search(ctx *context.APIContext) {
201201

202202
results := make([]*api.Repository, len(repos))
203203
for i, repo := range repos {
204-
if err = repo.GetOwner(ctx); err != nil {
204+
if err = repo.LoadOwner(ctx); err != nil {
205205
ctx.JSON(http.StatusInternalServerError, api.SearchError{
206206
OK: false,
207207
Error: err.Error(),

‎routers/api/v1/user/repo.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ func ListMyRepos(ctx *context.APIContext) {
119119

120120
results := make([]*api.Repository, len(repos))
121121
for i, repo := range repos {
122-
if err = repo.GetOwner(ctx); err != nil {
123-
ctx.Error(http.StatusInternalServerError, "GetOwner", err)
122+
if err = repo.LoadOwner(ctx); err != nil {
123+
ctx.Error(http.StatusInternalServerError, "LoadOwner", err)
124124
return
125125
}
126126
accessMode, err := access_model.AccessLevel(ctx, ctx.Doer, repo)

‎routers/web/repo/compare.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ func ParseCompareInfo(ctx *context.Context) *CompareInfo {
279279
}
280280
return nil
281281
}
282-
if err := ci.HeadRepo.GetOwner(ctx); err != nil {
282+
if err := ci.HeadRepo.LoadOwner(ctx); err != nil {
283283
if user_model.IsErrUserNotExist(err) {
284284
ctx.NotFound("GetUserByName", nil)
285285
} else {

‎routers/web/repo/http.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ func httpBase(ctx *context.Context) (h *serviceHandler) {
146146

147147
// don't allow anonymous pulls if organization is not public
148148
if isPublicPull {
149-
if err := repo.GetOwner(ctx); err != nil {
150-
ctx.ServerError("GetOwner", err)
149+
if err := repo.LoadOwner(ctx); err != nil {
150+
ctx.ServerError("LoadOwner", err)
151151
return
152152
}
153153

‎routers/web/repo/issue.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -2157,8 +2157,8 @@ func UpdatePullReviewRequest(ctx *context.Context) {
21572157
}
21582158
if reviewID < 0 {
21592159
// negative reviewIDs represent team requests
2160-
if err := issue.Repo.GetOwner(ctx); err != nil {
2161-
ctx.ServerError("issue.Repo.GetOwner", err)
2160+
if err := issue.Repo.LoadOwner(ctx); err != nil {
2161+
ctx.ServerError("issue.Repo.LoadOwner", err)
21622162
return
21632163
}
21642164

‎routers/web/repo/pull.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ func getForkRepository(ctx *context.Context) *repo_model.Repository {
119119
return nil
120120
}
121121

122-
if err := forkRepo.GetOwner(ctx); err != nil {
123-
ctx.ServerError("GetOwner", err)
122+
if err := forkRepo.LoadOwner(ctx); err != nil {
123+
ctx.ServerError("LoadOwner", err)
124124
return nil
125125
}
126126

@@ -1315,8 +1315,8 @@ func CleanUpPullRequest(ctx *context.Context) {
13151315
} else if err = pr.LoadBaseRepo(ctx); err != nil {
13161316
ctx.ServerError("LoadBaseRepo", err)
13171317
return
1318-
} else if err = pr.HeadRepo.GetOwner(ctx); err != nil {
1319-
ctx.ServerError("HeadRepo.GetOwner", err)
1318+
} else if err = pr.HeadRepo.LoadOwner(ctx); err != nil {
1319+
ctx.ServerError("HeadRepo.LoadOwner", err)
13201320
return
13211321
}
13221322

‎routers/web/repo/setting.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,7 @@ func SettingsPost(ctx *context.Context) {
650650
ctx.Error(http.StatusNotFound)
651651
return
652652
}
653-
if err := repo.GetOwner(ctx); err != nil {
653+
if err := repo.LoadOwner(ctx); err != nil {
654654
ctx.ServerError("Convert Fork", err)
655655
return
656656
}

‎routers/web/repo/view.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -1033,8 +1033,8 @@ func Forks(ctx *context.Context) {
10331033
}
10341034

10351035
for _, fork := range forks {
1036-
if err = fork.GetOwner(ctx); err != nil {
1037-
ctx.ServerError("GetOwner", err)
1036+
if err = fork.LoadOwner(ctx); err != nil {
1037+
ctx.ServerError("LoadOwner", err)
10381038
return
10391039
}
10401040
}

‎services/convert/issue.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func ToAPIIssue(ctx context.Context, issue *issues_model.Issue) *api.Issue {
3232
if err := issue.LoadRepo(ctx); err != nil {
3333
return &api.Issue{}
3434
}
35-
if err := issue.Repo.GetOwner(ctx); err != nil {
35+
if err := issue.Repo.LoadOwner(ctx); err != nil {
3636
return &api.Issue{}
3737
}
3838

0 commit comments

Comments
 (0)