Skip to content

Commit d6779c7

Browse files
authored
Fix public org members displayed too many informations (#20403)
1 parent 4c7e51e commit d6779c7

File tree

2 files changed

+23
-20
lines changed

2 files changed

+23
-20
lines changed

routers/web/org/members.go

+1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ func Members(ctx *context.Context) {
4545
}
4646
opts.PublicOnly = !isMember && !ctx.Doer.IsAdmin
4747
}
48+
ctx.Data["PublicOnly"] = opts.PublicOnly
4849

4950
total, err := organization.CountOrgMembers(opts)
5051
if err != nil {

templates/org/member/members.tmpl

+22-20
Original file line numberDiff line numberDiff line change
@@ -29,28 +29,30 @@
2929
{{end}}
3030
</div>
3131
</div>
32-
<div class="ui three wide column center">
33-
<div class="meta">
34-
{{$.locale.Tr "org.members.member_role"}}
35-
</div>
36-
<div class="meta">
37-
<strong>{{if index $.MembersIsUserOrgOwner .ID}}{{svg "octicon-shield-lock"}} {{$.locale.Tr "org.members.owner"}}{{else}}{{$.locale.Tr "org.members.member"}}{{end}}</strong>
38-
</div>
39-
</div>
40-
<div class="ui two wide column center">
41-
<div class="meta">
42-
{{$.locale.Tr "admin.users.2fa"}}
32+
{{if not .PublicOnly}}
33+
<div class="ui three wide column center">
34+
<div class="meta">
35+
{{$.locale.Tr "org.members.member_role"}}
36+
</div>
37+
<div class="meta">
38+
<strong>{{if index $.MembersIsUserOrgOwner .ID}}{{svg "octicon-shield-lock"}} {{$.locale.Tr "org.members.owner"}}{{else}}{{$.locale.Tr "org.members.member"}}{{end}}</strong>
39+
</div>
4340
</div>
44-
<div class="meta">
45-
<strong>
46-
{{if index $.MembersTwoFaStatus .ID}}
47-
<span class="text green">{{svg "octicon-check"}}</span>
48-
{{else}}
49-
{{svg "octicon-x"}}
50-
{{end}}
51-
</strong>
41+
<div class="ui two wide column center">
42+
<div class="meta">
43+
{{$.locale.Tr "admin.users.2fa"}}
44+
</div>
45+
<div class="meta">
46+
<strong>
47+
{{if index $.MembersTwoFaStatus .ID}}
48+
<span class="text green">{{svg "octicon-check"}}</span>
49+
{{else}}
50+
{{svg "octicon-x"}}
51+
{{end}}
52+
</strong>
53+
</div>
5254
</div>
53-
</div>
55+
{{end}}
5456
<div class="ui three wide column">
5557
<div class="text right">
5658
{{if eq $.SignedUser.ID .ID}}

0 commit comments

Comments
 (0)