Skip to content

Commit de6dfb7

Browse files
authored
Remove href="javascript:;" in "save topics (Done)" button (#21813)
To use an anchor tag as a button and have it be accessible I added `role="button" tabindex="0"`, [reference](https://stackoverflow.com/a/10510353/7414734). * Closes #19912
1 parent 55115db commit de6dfb7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: templates/repo/home.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
</div>
4848
</div>
4949
<div class="two wide column">
50-
<a class="ui button primary" href="javascript:;" id="save_topic"
50+
<a class="ui button primary" role="button" tabindex="0" id="save_topic"
5151
data-link="{{.RepoLink}}/topics">{{.locale.Tr "repo.topic.done"}}</a>
5252
</div>
5353
</div>

0 commit comments

Comments
 (0)