Fix invalid issue branch reference if not specified in template (#22513)

brechtvl · web-flow · commit e0a8965208f1 · 2023-01-18T16:50:22.000-05:00
When an issue template does not contain a ref, it would end up with an
invalid `ref/heads/` value instead of having no branch referenced .
diff --git a/routers/web/repo/issue.go b/routers/web/repo/issue.go
@@ -784,7 +784,8 @@ func setTemplateIfExists(ctx *context.Context, ctxDataKey string, possibleFiles
 			}
 
 		}
-		if !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>
+
+		if template.Ref != "" && !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>
 			template.Ref = git.BranchPrefix + template.Ref
 		}
 		ctx.Data["HasSelectedLabel"] = len(labelIDs) > 0

Original file line number	Diff line number	Diff line change
`@@ -784,7 +784,8 @@ func setTemplateIfExists(ctx *context.Context, ctxDataKey string, possibleFiles`
`784`	`784`	`}`
`785`	`785`
`786`	`786`	`}`
`787`		`- if !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>`
	`787`	`+`
	`788`	`+ if template.Ref != "" && !strings.HasPrefix(template.Ref, "refs/") { // Assume that the ref intended is always a branch - for tags users should use refs/tags/<ref>`
`788`	`789`	`template.Ref = git.BranchPrefix + template.Ref`
`789`	`790`	`}`
`790`	`791`	`ctx.Data["HasSelectedLabel"] = len(labelIDs) > 0`