Skip to content

Commit e938266

Browse files
authored
Add missing commit states to PR checks template (#11085)
* Add missing commit states to PR checks template * Add separate translation strings for warning and error * Fix failure status string * Revert accidental change with whitespace
1 parent 9ffa892 commit e938266

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

options/locale/locale_en-US.ini

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1134,7 +1134,9 @@ pulls.push_rejected_no_message = Merge Failed: The push was rejected but there w
11341134
pulls.open_unmerged_pull_exists = `You cannot perform a reopen operation because there is a pending pull request (#%d) with identical properties.`
11351135
pulls.status_checking = Some checks are pending
11361136
pulls.status_checks_success = All checks were successful
1137-
pulls.status_checks_error = Some checks failed
1137+
pulls.status_checks_warning = Some checks reported warnings
1138+
pulls.status_checks_failure = Some checks failed
1139+
pulls.status_checks_error = Some checks reported errors
11381140
pulls.update_branch = Update branch
11391141
pulls.update_branch_success = Branch update was successful
11401142
pulls.update_not_allowed = You are not allowed to update branch

templates/repo/pulls/status.tmpl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
{{$.i18n.Tr "repo.pulls.status_checking"}}
55
{{else if eq .LatestCommitStatus.State "success"}}
66
{{$.i18n.Tr "repo.pulls.status_checks_success"}}
7+
{{else if eq .LatestCommitStatus.State "warning"}}
8+
{{$.i18n.Tr "repo.pulls.status_checks_warning"}}
9+
{{else if eq .LatestCommitStatus.State "failure"}}
10+
{{$.i18n.Tr "repo.pulls.status_checks_failure"}}
711
{{else if eq .LatestCommitStatus.State "error"}}
812
{{$.i18n.Tr "repo.pulls.status_checks_error"}}
913
{{else}}

0 commit comments

Comments
 (0)