Skip to content

GPG: Failed to extract signature #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
strk opened this issue Sep 10, 2017 · 9 comments
Closed

GPG: Failed to extract signature #2481

strk opened this issue Sep 10, 2017 · 9 comments

Comments

@strk
Copy link
Member

strk commented Sep 10, 2017

See https://try.gitea.io/strk/test/commit/bf48a08fdfa2bdfbede039a8fa9df10163307bca

Reproducing locally the error in the logs is:

 [E] SignatureRead err: Packet is not a signature

The commit was created with git commit -S

@strk
Copy link
Member Author

strk commented Sep 10, 2017

\cc @sapk

@lunny lunny added the type/bug label Sep 10, 2017
@lunny lunny added this to the 1.x.x milestone Sep 10, 2017
@sapk
Copy link
Member

sapk commented Sep 10, 2017

@strk for information, the error should come directly for the lib the read the signature that we send to it. ~~~It maybe git output that has change with a updated version.~~~ I will have a look at it.

@sapk
Copy link
Member

sapk commented Sep 10, 2017

Debug information :

[git-module] Hit cache: b1914b4ea57cb895b132523411756ea757ef4959
[git-module] /home/sapk/gitea-repositories/sapk/test.git: git cat-file -p bf48a08fdfa2bdfbede039a8fa9df10163307bca
[git-module] stdout:
tree 489acf7437dc1358f89d1caf2a35bf811b8735b8
parent 7f841d9536824aca71d5e87b2134252d2b82da5c
author Sandro Santilli [email protected] 1505039757 +0200
committer Sandro Santilli [email protected] 1505039757 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iD8DBQBZtRWO1sB9pKxWLa0RAiyqAJ9b2jhppgMPcQuBGFqJUcTrGqC03ACfc8k9
6Sr9qaW035WmIgQ27rnY7tc=
=Bha/
-----END PGP SIGNATURE-----

removed line

[git-module] /home/sapk/gitea-repositories/sapk/test.git: git cat-file -p 7f841d9536824aca71d5e87b2134252d2b82da5c
[git-module] stdout:
tree e23e39c8831256eca3af1e27ce26709c94780b9d
parent 1137dc6c0440a026cd19243bd13932c347aa49e6
author strk [email protected] 1485347664 +0000
committer strk [email protected] 1485347664 +0000

Delete 'README.md'

[git-module] /home/sapk/gitea-repositories/sapk/test.git: git cat-file -p 1137dc6c0440a026cd19243bd13932c347aa49e6
[git-module] stdout:
tree ad2ac0650909f5bbf301809e7333ca91fd33395b
parent 6b3196faa95b59af6d60c5c9f454e25839adc114
author strk [email protected] 1485347648 +0000
committer strk [email protected] 1485347648 +0000

Add 'README.txt'

[git-module] /home/sapk/gitea-repositories/sapk/test.git: git cat-file -p 6b3196faa95b59af6d60c5c9f454e25839adc114
[git-module] stdout:
tree cbc8f992c75642f59ce9a92a91b5091a3f1d72df
author strk [email protected] 1485347633 +0000
committer Gogs [email protected] 1485347633 +0000

Initial commit

[{"id":26,"primary_key_id":"","key_id":"D6C07DA4AC562DAD","public_key":"xsDiBD+ntCQRBACEG9LH4KfeIkX9rA6QYBFOnJITj+qzOAqpLwMDic1tPvZw8yQ4QGJK3T45aPqHDfx7h2PhSn0qVQ7G8BuhRnIbtuIp4Ifft9dLhWO3t8snw1SYlAOS1m8PHsOIq2bp+rvoHLl8aBWXEOX7sUrxSxU+k097BVicOiF4Aag8wdHIBwCgn1Y/pt5n886NDaRTPDFJsG9CrfUD/0vqVcNLiJNX95OxHoa/Gz9v5anznDzyt6FzvUs2aet2z5XZSzRWSiULxuO1AHscz9b4P6R1MLqzdwqS7KJgOcjd1x2zan2jq3Z8IhiYgXcx8Jbejsmp/wkdI7wKbJI6c0XYE6A++n8QNWC/8f/6fpXnD/ZeVXuI7Atu99XK5zPABACCdxkCv3xbI/z73AtrZVkBRlY5RuItuk8Bm3kaRpN7+zm499kXve4PC8zeFxGWwQKUSnSdD8FBH8oLzWFRYo2BGQfaeGTFqYEYHZZZirNaLjW4DkCOXPjgj9gDln4m9QJCp++3jCPDfr0Ck2X0EkEV2l8O2W+q3MW1GGdmshRVNA==","emails":[{"email":"[email protected]","verified":true}],"subkeys":[{"id":27,"primary_key_id":"D6C07DA4AC562DAD","key_id":"A1B822DE19ADCCA4","public_key":"zsBNBD+ntCUQBADN5obXyq8JZsFf1DpMEiKjk8muNaLePnF/fkbPYOTJ7M+T5XFR5giiVbeCjz6A0r737eZgrEPR9B+CRneOzmrX23b+s08FBrYCqz+H8itEWZcRDClK5iPiJI3Kol6rfYMsKOTJfYRc3nObcycEkufiFVP18u8OrF2RhnQFmJNXRwADBwP/ff/6OInxeMHL8T9Qwmis1hsMqZt90gRemIhzaviIuA0XJ+sR6hQ74bmEzYPfntMP9zwAjkZX7DUu0775Olr69nQifYZiPqGzwVDu7QYtL/4KcQ5J3bTcicjU3dZ55Dg0ABrGjCFY8geiG+yoxgVWsAyB0OOvD+WCWFHREzzY3mU=","emails":null,"subkeys":null,"can_sign":false,"can_encrypt_comms":true,"can_encrypt_storage":true,"can_certify":false,"created_at":"2003-11-04T14:13:57Z","expires_at":"0001-01-01T00:00:00Z"}],"can_sign":true,"can_encrypt_comms":false,"can_encrypt_storage":false,"can_certify":true,"created_at":"2003-11-04T14:13:56Z","expires_at":"0001-01-01T00:00:00Z"}]

@sapk
Copy link
Member

sapk commented Sep 10, 2017

I can reproduce localy and add a test. I will try to find what is wrong.

What I have found that it not the output of that has change. The sign is extract but the lib used for gpg doesn't validate the signature format ...

updating lib doesn't fix ...

@strk
Copy link
Member Author

strk commented Sep 10, 2017 via email

@stale
Copy link

stale bot commented Feb 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 13, 2019
@lunny
Copy link
Member

lunny commented Feb 13, 2019

Is this still a problem?

@stale stale bot removed the issue/stale label Feb 13, 2019
@stale
Copy link

stale bot commented Apr 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 14, 2019
@techknowlogick
Copy link
Member

Closing due to lack of feedback. Please re-open if needed 😄

@lunny lunny removed this from the 1.x.x milestone Apr 17, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants