Gitea v1.23.7 crashes on force-push to existing PR

[andrewimeson]

Description

Since upgrading to Gitea 1.23.7 (previously on 1.22.6) last week we have had two Gitea application crashes after I force pushed to an existing branch with a PR. The first time I had to delete a corrupted Bleve index to get Gitea started again.

I captured the last logs from the pod crash on the second crash

2025/04/21 14:08:44 .../graceful/manager.go:86:func1() [E] PANIC during RunWithShutdownContext: runtime error: invalid memory address or nil pointer dereference
Stacktrace: /usr/local/go/src/runtime/panic.go:262 (0x47bad8)
/usr/local/go/src/runtime/signal_unix.go:917 (0x47baa8)
/go/src/code.gitea.io/gitea/models/issues/comment.go:347 (0x20fa62a)
/go/src/code.gitea.io/gitea/services/issue/assignee.go:256 (0x20fa636)
/go/src/code.gitea.io/gitea/services/issue/assignee.go:246 (0x20fa478)
/go/src/code.gitea.io/gitea/services/pull/pull.go:453 (0x2128a34)
/go/src/code.gitea.io/gitea/modules/graceful/manager.go:92 (0xc97f9a)
/go/src/code.gitea.io/gitea/services/pull/pull.go:366 (0x2127baf)
/usr/local/go/src/runtime/asm_amd64.s:1700 (0x482060)
2025/04/21 14:08:44 ...eful/server_hooks.go:46:doShutdown() [I] PID: 7 Listener ([::]:2222) closed.
2025/04/21 14:08:44 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/events for 172.22.1.132:52768, 200 OK in 1795381.0ms @ events/events.go:18(events.Events)
2025/04/21 14:08:44 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/events for 172.22.1.132:49918, 200 OK in 362813.7ms @ events/events.go:18(events.Events)
2025/04/21 14:08:44 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/events for 172.22.1.132:57122, 200 OK in 651246.4ms @ events/events.go:18(events.Events)
2025/04/21 14:08:44 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/events for 172.22.1.132:60322, 200 OK in 241506.3ms @ events/events.go:18(events.Events)
2025/04/21 14:08:44 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/events for 172.22.1.132:60608, 200 OK in 595014.4ms @ events/events.go:18(events.Events)
2025/04/21 14:08:44 ...eb/routing/logger.go:102:func1() [I] router: completed GET /user/events for 172.22.1.132:37466, 200 OK in 1788841.8ms @ events/events.go:18(events.Events)
2025/04/21 14:08:44 cmd/web.go:366:listen() [I] HTTP Listener: 0.0.0.0:3000 Closed
2025/04/21 14:08:44 ...eful/server_hooks.go:46:doShutdown() [I] PID: 7 Listener ([::]:3000) closed.
2025/04/21 14:09:44 .../graceful/manager.go:168:doHammerTime() [W] Setting Hammer condition
2025/04/21 14:09:44 ...eful/server_hooks.go:63:doHammer() [W] Forcefully shutting down parent
2025/04/21 14:09:44 .../ssh/ssh_graceful.go:28:listen() [I] SSH Listener: :2222 Closed
2025/04/21 14:09:45 .../graceful/manager.go:184:doTerminate() [W] Terminating
2025/04/21 14:09:45 ...er/issues/indexer.go:120:2() [I] PID: 7 Issue Indexer closed
2025/04/21 14:09:45 ...exer/code/indexer.go:112:func1() [I] PID: 7 Repository Indexer closed
2025/04/21 14:09:45 ...eful/manager_unix.go:154:handleSignals() [W] PID: 7. Background context for manager closed - context canceled - Shutting down...
2025/04/21 14:09:45 cmd/web.go:225:serveInstalled() [I] PID: 7 Gitea Web Finished

Gitea Version

1.23.7

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.47.2

Operating System

Alpine Linux v3.21

How are you running Gitea?

Gitea Helm chart v9.5.1 with non-HA Postgres on Kubernetes.

Database

PostgreSQL

[wxiaoguang]

services/pull/pull.go:453

Related to "Pull request updates will also trigger code owners review requests (#33744) (#34045)"

@lunny