Skip to content

Feature request: Expand diff for more context #5263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BhaaLseN opened this issue Nov 3, 2018 · 6 comments
Closed

Feature request: Expand diff for more context #5263

BhaaLseN opened this issue Nov 3, 2018 · 6 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone
1.11.0

Comments

@BhaaLseN
Copy link

BhaaLseN commented Nov 3, 2018 •
edited
Loading

GitHub allows a diff to be expanded, in case more context than the configured context lines is needed for a review. Clicking the symbol above/below the lines numbers here:
Expand Context
expands the diff in the respective direction to show more context:
More context

Update: GitHub now supports expanding both ways for files that have more than one hunk of change.
Expand goes both ways
@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Nov 3, 2018
@stale
Copy link

stale bot commented Jan 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 4, 2019
@lafriks lafriks added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Jan 4, 2019
@shaba
Copy link

shaba commented Mar 21, 2019

+1

@starhel
Copy link

starhel commented Sep 17, 2019

+1 This is probably one of the most important features allowing fast and pleasant code review.

@Maximusya
Copy link

Yes, please

@petrdunaj
Copy link

petrdunaj commented Nov 28, 2019 •
edited
Loading

please +1

@guillep2k
Copy link
Member

This has been implemented in #8924

@lunny lunny closed this as completed Nov 28, 2019
@lunny lunny added this to the 1.11.0 milestone Nov 28, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
8 participants
@lunny @lafriks @shaba @BhaaLseN @Maximusya @starhel @petrdunaj @guillep2k