Skip to content

Add checks when the binary is moved or other crucial changes #8215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guillep2k opened this issue Sep 17, 2019 · 7 comments
Closed

Add checks when the binary is moved or other crucial changes #8215

guillep2k opened this issue Sep 17, 2019 · 7 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@guillep2k
Copy link
Member

  • Gitea version (or commit ref): 1.9.3

Description

Ref: #8208

If a user changes gitea binary location, the server seems to work initially, but fails later when users attempt to push commits.

We should have some check of where the server was installed the last time and update hooks and authorized_keys automatically or at least give the user some warnings.

Perhaps there are other nice checks that can be done at startup.

@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 18, 2019
@lunny
Copy link
Member

lunny commented Sep 18, 2019

We could randomly chose one repository and generate a new script and compare it with that script on repositories to test if it's the same. We can give a warning information on console or admin UI or notification?

@bagasme
Copy link
Contributor

bagasme commented Sep 29, 2019

@lunny warnings should be thrown on both console and admin UI.

@stale
Copy link

stale bot commented Nov 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Nov 28, 2019
@guillep2k
Copy link
Member Author

I think this check should be done at the instance start. It could share some code with "the doctor".

@stale stale bot removed the issue/stale label Nov 28, 2019
@lunny
Copy link
Member

lunny commented Nov 29, 2019

@guillep2k if you have many repository, this operation will spend many time when start. I don't think it's necessary to check that when start. A doctor command should be better.

As I said, if you really want to check that, we can chose some of repositories randomly to check but not every one.

@guillep2k
Copy link
Member Author

Yes, I just wanted to ping the stale-bot, sorry.

@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Nov 29, 2019
@lunny
Copy link
Member

lunny commented Nov 29, 2019

Aha, @Stale !

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants