From 98e4ef9465f7c47664431a9527602360880b3671 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 9 Jun 2021 20:53:48 +0800 Subject: [PATCH 1/3] Fix bug on getIssueIDsByRepoID --- models/issue.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/issue.go b/models/issue.go index 6912df6c28ac7..760aaaab09694 100644 --- a/models/issue.go +++ b/models/issue.go @@ -1086,7 +1086,7 @@ func getIssuesByIDs(e Engine, issueIDs []int64) ([]*Issue, error) { func getIssueIDsByRepoID(e Engine, repoID int64) ([]int64, error) { ids := make([]int64, 0, 10) - err := e.Table("issue").Where("repo_id = ?", repoID).Find(&ids) + err := e.Table("issue").Cols("id").Where("repo_id = ?", repoID).Find(&ids) return ids, err } From 2dd6dae24c31d262645cd2b60d9973d0e699e1b6 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 9 Jun 2021 20:58:04 +0800 Subject: [PATCH 2/3] Add test --- models/issue_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/models/issue_test.go b/models/issue_test.go index c21b1d6ae98e6..6f886082ee3de 100644 --- a/models/issue_test.go +++ b/models/issue_test.go @@ -36,6 +36,14 @@ func TestIssue_ReplaceLabels(t *testing.T) { testSuccess(1, []int64{}) } +func Test_GetIssueIDsByRepoID(t *testing.T) { + assert.NoError(t, PrepareTestDatabase()) + + ids, err := GetIssueIDsByRepoID(1) + assert.NoError(t, err) + assert.Len(t, ids, 6) +} + func TestIssueAPIURL(t *testing.T) { assert.NoError(t, PrepareTestDatabase()) issue := AssertExistsAndLoadBean(t, &Issue{ID: 1}).(*Issue) From 667ea2db658341fa4806aebd1cf77ff1e578e849 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Wed, 9 Jun 2021 23:13:53 +0800 Subject: [PATCH 3/3] Fix test --- models/issue_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/issue_test.go b/models/issue_test.go index 6f886082ee3de..b612ab267b43b 100644 --- a/models/issue_test.go +++ b/models/issue_test.go @@ -41,7 +41,7 @@ func Test_GetIssueIDsByRepoID(t *testing.T) { ids, err := GetIssueIDsByRepoID(1) assert.NoError(t, err) - assert.Len(t, ids, 6) + assert.Len(t, ids, 5) } func TestIssueAPIURL(t *testing.T) {