fixed warnings ifElseChain (#187)

* fixed warnings ifElseChain

* fmt fix

Author: kveselkov

compare.go

@@ -69,11 +69,13 @@ func (l *Conn) Compare(dn, attribute, value string) (bool, error) {
 
 	if packet.Children[1].Tag == ApplicationCompareResponse {
 		resultCode, resultDescription := getLDAPResultCode(packet)
-		if resultCode == LDAPResultCompareTrue {
+
+		switch {
+		case resultCode == LDAPResultCompareTrue:
 			return true, nil
-		} else if resultCode == LDAPResultCompareFalse {
+		case resultCode == LDAPResultCompareFalse:
 			return false, nil
-		} else {
+		default:
 			return false, NewError(resultCode, errors.New(resultDescription))
 		}
 	}

dn.go

@@ -90,7 +90,8 @@ func ParseDN(str string) (*DN, error) {
 
 	for i := 0; i < len(str); i++ {
 		char := str[i]
-		if escaping {
+		switch {
+		case escaping:
 			unescapedTrailingSpaces = 0
 			escaping = false
 			switch char {
@@ -112,10 +113,10 @@ func ParseDN(str string) (*DN, error) {
 			}
 			buffer.WriteByte(dst[0])
 			i++
-		} else if char == '\\' {
+		case char == '\\':
 			unescapedTrailingSpaces = 0
 			escaping = true
-		} else if char == '=' {
+		case char == '=':
 			attribute.Type = stringFromBuffer()
 			// Special case: If the first character in the value is # the
 			// following data is BER encoded so we can just fast forward
@@ -140,7 +141,7 @@ func ParseDN(str string) (*DN, error) {
 				buffer.WriteString(packet.Data.String())
 				i += len(data) - 1
 			}
-		} else if char == ',' || char == '+' {
+		case char == ',' || char == '+':
 			// We're done with this RDN or value, push it
 			if len(attribute.Type) == 0 {
 				return nil, errors.New("incomplete type, value pair")
@@ -153,10 +154,10 @@ func ParseDN(str string) (*DN, error) {
 				rdn = new(RelativeDN)
 				rdn.Attributes = make([]*AttributeTypeAndValue, 0)
 			}
-		} else if char == ' ' && buffer.Len() == 0 {
+		case char == ' ' && buffer.Len() == 0:
 			// ignore unescaped leading spaces
 			continue
-		} else {
+		default:
 			if char == ' ' {
 				// Track unescaped spaces in case they are trailing and we need to remove them
 				unescapedTrailingSpaces++

filter_test.go

@@ -195,13 +195,14 @@ func TestFilter(t *testing.T) {
 	// Test Compiler and Decompiler
 	for _, i := range testFilters {
 		filter, err := CompileFilter(i.filterStr)
-		if err != nil {
+		switch {
+		case err != nil:
 			if i.expectedErr == "" || !strings.Contains(err.Error(), i.expectedErr) {
 				t.Errorf("Problem compiling '%s' - '%v' (expected error to contain '%v')", i.filterStr, err, i.expectedErr)
 			}
-		} else if filter.Tag != ber.Tag(i.expectedType) {
+		case filter.Tag != ber.Tag(i.expectedType):
 			t.Errorf("%q Expected %q got %q", i.filterStr, FilterMap[uint64(i.expectedType)], FilterMap[uint64(filter.Tag)])
-		} else {
+		default:
 			o, err := DecompileFilter(filter)
 			if err != nil {
 				t.Errorf("Problem compiling %s - %s", i.filterStr, err.Error())