lint - fix all staticcheck

Author: atercattus

client/client_test.go

@@ -309,11 +309,13 @@ func (s *clientTestSuite) TestStmt_NULL(c *C) {
 
 	str = `select * from mixer_test_stmt where id = ?`
 	stmt, err = s.c.Prepare(str)
+	c.Assert(err, IsNil)
+
 	defer stmt.Close()
 
+	result, err = stmt.Execute(2)
 	c.Assert(err, IsNil)
 
-	result, err = stmt.Execute(2)
 	b, err := result.IsNullByName(0, "id")
 	c.Assert(err, IsNil)
 	c.Assert(b, Equals, false)

client/resp.go

@@ -101,6 +101,10 @@ func (c *Conn) handleAuthResult() error {
 		}
 		c.authPluginName = switchToPlugin
 		auth, addNull, err := c.genAuthResponse(data)
+		if err != nil {
+			return err
+		}
+
 		if err = c.WriteAuthSwitchPacket(auth, addNull); err != nil {
 			return err
 		}

cmd/go-canal/main.go

@@ -89,8 +89,7 @@ func main() {
 
 	sc := make(chan os.Signal, 1)
 	signal.Notify(sc,
-		os.Kill,
-		os.Interrupt,
+		syscall.SIGINT,
 		syscall.SIGHUP,
 		syscall.SIGINT,
 		syscall.SIGTERM,

dump/dump_test.go

@@ -268,7 +268,7 @@ func (s *parserTestSuite) TestParseValue(c *C) {
 	c.Assert(values, HasLen, 4)
 
 	str = `123,'\Z#÷QÎx£. Æ‘ÇoPâÅ_\r—\\','','qn\'`
-	values, err = parseValues(str)
+	_, err = parseValues(str)
 	c.Assert(err, NotNil)
 }
 

failover/failover_test.go

@@ -108,7 +108,7 @@ func (s *failoverTestSuite) testFailover(c *C, h Handler, m *Server, s1 *Server,
 	err = s2.StopSlaveIOThread()
 	c.Assert(err, IsNil)
 
-	id = s.checkInsert(c, m, "b")
+	_ = s.checkInsert(c, m, "b")
 	id = s.checkInsert(c, m, "c")
 
 	err = h.WaitCatchMaster(s1, m)
@@ -138,7 +138,7 @@ func (s *failoverTestSuite) testFailover(c *C, h Handler, m *Server, s1 *Server,
 	c.Assert(err, IsNil)
 
 	m, s1 = s1, m
-	id = s.checkInsert(c, m, "d")
+	_ = s.checkInsert(c, m, "d")
 
 	err = h.WaitCatchMaster(s1, m)
 	c.Assert(err, IsNil)
@@ -153,8 +153,9 @@ func (s *failoverTestSuite) testFailover(c *C, h Handler, m *Server, s1 *Server,
 	err = s2.StopSlaveIOThread()
 	c.Assert(err, IsNil)
 
-	id = s.checkInsert(c, m, "e")
+	_ = s.checkInsert(c, m, "e")
 	err = h.WaitCatchMaster(s1, m)
+	c.Assert(err, IsNil)
 
 	best, err = h.FindBestSlaves([]*Server{s1, s2})
 	c.Assert(err, IsNil)

mysql/errcode.go

@@ -32,8 +32,10 @@ func parseInterval(str string) (i Interval, err error) {
 		i.Stop = i.Start + 1
 	case 2:
 		i.Start, err = strconv.ParseInt(p[0], 10, 64)
-		i.Stop, err = strconv.ParseInt(p[1], 10, 64)
-		i.Stop = i.Stop + 1
+		if err == nil {
+			i.Stop, err = strconv.ParseInt(p[1], 10, 64)
+			i.Stop++
+		}
 	default:
 		err = errors.Errorf("invalid interval format, must n[-n]")
 	}
@@ -432,7 +434,7 @@ func (s *MysqlGTIDSet) String() string {
 		sets = append(sets, set.String())
 	}
 	sort.Strings(sets)
-	
+
 	sep := ""
 	for _, set := range sets {
 		buf.WriteString(sep)

mysql/mysql_gtid.go

@@ -80,7 +80,7 @@ func (p *BinlogParser) ParseFile(name string, offset int64, onEvent OnEventFunc)
 		offset = 4
 	} else if offset > 4 {
 		//  FORMAT_DESCRIPTION event should be read by default always (despite that fact passed offset may be higher than 4)
-		if _, err = f.Seek(4, os.SEEK_SET); err != nil {
+		if _, err = f.Seek(4, io.SeekStart); err != nil {
 			return errors.Errorf("seek %s to %d error %v", name, offset, err)
 		}
 
@@ -89,7 +89,7 @@ func (p *BinlogParser) ParseFile(name string, offset int64, onEvent OnEventFunc)
 		}
 	}
 
-	if _, err = f.Seek(offset, os.SEEK_SET); err != nil {
+	if _, err = f.Seek(offset, io.SeekStart); err != nil {
 		return errors.Errorf("seek %s to %d error %v", name, offset, err)
 	}
 

replication/parser.go

@@ -1097,11 +1097,7 @@ func (e *RowsEvent) decodeValue(data []byte, tp byte, meta uint16) (v interface{
 		if i32 == 0 {
 			v = "00:00:00"
 		} else {
-			sign := ""
-			if i32 < 0 {
-				sign = "-"
-			}
-			v = fmt.Sprintf("%s%02d:%02d:%02d", sign, i32/10000, (i32%10000)/100, i32%100)
+			v = fmt.Sprintf("%02d:%02d:%02d", i32/10000, (i32%10000)/100, i32%100)
 		}
 	case MYSQL_TYPE_TIME2:
 		v, n, err = decodeTime2(data, meta)

replication/row_event.go

@@ -31,6 +31,6 @@ func ByteSlicePut(data []byte) {
 	select {
 	case byteSliceChan <- data:
 	default:
-		byteSlicePool.Put(data)
+		byteSlicePool.Put(data) //nolint:staticcheck
 	}
 }