Skip to content

Commit 58e3165

Browse files
authored
Merge pull request #798 from masahide/patch-1
Support LOCAL INFILE request
2 parents 29bc749 + 2d69dd7 commit 58e3165

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

client/auth.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,8 @@ func (c *Conn) writeAuthHandshake() error {
202202
capability |= c.ccaps&CLIENT_FOUND_ROWS | c.ccaps&CLIENT_IGNORE_SPACE |
203203
c.ccaps&CLIENT_MULTI_STATEMENTS | c.ccaps&CLIENT_MULTI_RESULTS |
204204
c.ccaps&CLIENT_PS_MULTI_RESULTS | c.ccaps&CLIENT_CONNECT_ATTRS |
205-
c.ccaps&CLIENT_COMPRESS | c.ccaps&CLIENT_ZSTD_COMPRESSION_ALGORITHM
205+
c.ccaps&CLIENT_COMPRESS | c.ccaps&CLIENT_ZSTD_COMPRESSION_ALGORITHM |
206+
c.ccaps&CLIENT_LOCAL_FILES
206207

207208
// To enable TLS / SSL
208209
if c.tlsConfig != nil {

client/resp.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ func (c *Conn) readResultColumns(result *Result) (err error) {
344344
rawPkgLen := len(result.RawPkg)
345345
result.RawPkg, err = c.ReadPacketReuseMem(result.RawPkg)
346346
if err != nil {
347-
return
347+
return err
348348
}
349349
data = result.RawPkg[rawPkgLen:]
350350

@@ -361,15 +361,15 @@ func (c *Conn) readResultColumns(result *Result) (err error) {
361361
err = ErrMalformPacket
362362
}
363363

364-
return
364+
return err
365365
}
366366

367367
if result.Fields[i] == nil {
368368
result.Fields[i] = &Field{}
369369
}
370370
err = result.Fields[i].Parse(data)
371371
if err != nil {
372-
return
372+
return err
373373
}
374374

375375
result.FieldNames[hack.String(result.Fields[i].Name)] = i
@@ -385,7 +385,7 @@ func (c *Conn) readResultRows(result *Result, isBinary bool) (err error) {
385385
rawPkgLen := len(result.RawPkg)
386386
result.RawPkg, err = c.ReadPacketReuseMem(result.RawPkg)
387387
if err != nil {
388-
return
388+
return err
389389
}
390390
data = result.RawPkg[rawPkgLen:]
391391

@@ -434,7 +434,7 @@ func (c *Conn) readResultRowsStreaming(result *Result, isBinary bool, perRowCb S
434434
for {
435435
data, err = c.ReadPacketReuseMem(data[:0])
436436
if err != nil {
437-
return
437+
return err
438438
}
439439

440440
// EOF Packet

mysql/field.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -49,42 +49,42 @@ func (f *Field) Parse(p FieldData) (err error) {
4949
//skip catelog, always def
5050
n, err = SkipLengthEncodedString(p)
5151
if err != nil {
52-
return
52+
return err
5353
}
5454
pos += n
5555

5656
//schema
5757
f.Schema, _, n, err = LengthEncodedString(p[pos:])
5858
if err != nil {
59-
return
59+
return err
6060
}
6161
pos += n
6262

6363
//table
6464
f.Table, _, n, err = LengthEncodedString(p[pos:])
6565
if err != nil {
66-
return
66+
return err
6767
}
6868
pos += n
6969

7070
//org_table
7171
f.OrgTable, _, n, err = LengthEncodedString(p[pos:])
7272
if err != nil {
73-
return
73+
return err
7474
}
7575
pos += n
7676

7777
//name
7878
f.Name, _, n, err = LengthEncodedString(p[pos:])
7979
if err != nil {
80-
return
80+
return err
8181
}
8282
pos += n
8383

8484
//org_name
8585
f.OrgName, _, n, err = LengthEncodedString(p[pos:])
8686
if err != nil {
87-
return
87+
return err
8888
}
8989
pos += n
9090

@@ -123,7 +123,7 @@ func (f *Field) Parse(p FieldData) (err error) {
123123

124124
if pos+int(f.DefaultValueLength) > len(p) {
125125
err = ErrMalformPacket
126-
return
126+
return err
127127
}
128128

129129
//default value string[$len]

0 commit comments

Comments
 (0)