Skip to content

Commit 59d2309

Browse files
committed
log errors
1 parent d9128d8 commit 59d2309

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

canal/canal.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import (
1919
"github.com/go-mysql-org/go-mysql/schema"
2020
"github.com/pingcap/errors"
2121
"github.com/pingcap/parser"
22+
"github.com/siddontang/go-log/log"
2223
)
2324

2425
// Canal can sync your MySQL data into everywhere, like Elasticsearch, Redis, etc...
@@ -221,12 +222,14 @@ func (c *Canal) run() error {
221222
close(c.dumpDoneCh)
222223

223224
if err != nil {
225+
log.Errorf("canal dump mysql err: %v", err)
224226
return errors.Trace(err)
225227
}
226228
}
227229

228230
if err := c.runSyncBinlog(); err != nil {
229231
if errors.Cause(err) != context.Canceled {
232+
log.Errorf("canal start sync binlog err: %v", err)
230233
return errors.Trace(err)
231234
}
232235
}
@@ -235,7 +238,7 @@ func (c *Canal) run() error {
235238
}
236239

237240
func (c *Canal) Close() {
238-
c.cfg.Logger.Infof("closing canal")
241+
log.Infof("closing canal")
239242
c.m.Lock()
240243
defer c.m.Unlock()
241244

@@ -349,6 +352,8 @@ func (c *Canal) GetTable(db string, table string) (*schema.Table, error) {
349352
c.tableLock.Lock()
350353
c.errorTablesGetTime[key] = time.Now()
351354
c.tableLock.Unlock()
355+
// log error and return ErrMissingTableMeta
356+
log.Errorf("canal get table meta err: %v", errors.Trace(err))
352357
return nil, schema.ErrMissingTableMeta
353358
}
354359
return nil, err

0 commit comments

Comments
 (0)