Merge pull request #572 from lance6716/fix-clone

fix a bug that not cloned to original memory

Author: lance6716

mysql/mysql_gtid.go

@@ -294,7 +294,7 @@ func (s *UUIDSet) Decode(data []byte) error {
 func (s *UUIDSet) Clone() *UUIDSet {
 	clone := new(UUIDSet)
 
-	copy(clone.SID.Bytes(), s.SID.Bytes())
+	copy(clone.SID[:], s.SID[:])
 	clone.Intervals = s.Intervals.Normalize()
 
 	return clone

mysql/mysql_test.go

@@ -214,3 +214,12 @@ func (t *mysqlTestSuite) TestMysqlNullDecode(c *check.C) {
 	c.Assert(isNull, check.IsTrue)
 	c.Assert(n, check.Equals, 1)
 }
+
+func (t *mysqlTestSuite) TestMysqlUUIDClone(c *check.C) {
+	us, err := ParseUUIDSet("de278ad0-2106-11e4-9f8e-6edd0ca20947:1-2")
+	c.Assert(err, check.IsNil)
+	c.Assert(us.String(), check.Equals, "de278ad0-2106-11e4-9f8e-6edd0ca20947:1-2")
+
+	clone := us.Clone()
+	c.Assert(clone.String(), check.Equals, "de278ad0-2106-11e4-9f8e-6edd0ca20947:1-2")
+}