added test for readPluginName

Author: skoef

server/handshake_resp_test.go

@@ -53,6 +53,76 @@ func TestDecodeFirstPart(t *testing.T) {
 	}
 }
 
+func TestReadPluginName(t *testing.T) {
+	// example data from
+	// https://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::HandshakeResponse41
+	mysqlNativePassword := []byte{
+		0x54, 0x00, 0x00, 0x01, 0x8d, 0xa6, 0x0f, 0x00, 0x00, 0x00, 0x00,
+		0x01, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+		0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+		0x00, 0x00, 0x00, 0x70, 0x61, 0x6d, 0x00, 0x14, 0xab, 0x09, 0xee,
+		0xf6, 0xbc, 0xb1, 0x32, 0x3e, 0x61, 0x14, 0x38, 0x65, 0xc0, 0x99,
+		0x1d, 0x95, 0x7d, 0x75, 0xd4, 0x47, 0x74, 0x65, 0x73, 0x74, 0x00,
+		0x6d, 0x79, 0x73, 0x71, 0x6c, 0x5f, 0x6e, 0x61, 0x74, 0x69, 0x76,
+		0x65, 0x5f, 0x70, 0x61, 0x73, 0x73, 0x77, 0x6f, 0x72, 0x64, 0x00,
+	}
+
+	// altered example data so it has different auth plugin
+	otherPlugin := []byte{
+		0x54, 0x00, 0x00, 0x01, 0x8d, 0xa6, 0x0f, 0x00, 0x00, 0x00, 0x00,
+		0x01, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+		0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+		0x00, 0x00, 0x00, 0x70, 0x61, 0x6d, 0x00, 0x14, 0xab, 0x09, 0xee,
+		0xf6, 0xbc, 0xb1, 0x32, 0x3e, 0x61, 0x14, 0x38, 0x65, 0xc0, 0x99,
+		0x1d, 0x95, 0x7d, 0x75, 0xd4, 0x47, 0x74, 0x65, 0x73, 0x74, 0x00,
+		0x66, 0x6f, 0x6f, 0x62, 0x61, 0x72, 0x00,
+	}
+
+	t.Run("mysql_native_password from plugin name", func(t *testing.T) {
+		c := &Conn{}
+		c.SetCapability(mysql.CLIENT_PLUGIN_AUTH)
+		pos := 66
+
+		pos = c.readPluginName(mysqlNativePassword, pos)
+		if pos != 88 {
+			t.Fatalf("unexpected pos, got %d", pos)
+		}
+
+		if c.authPluginName != "mysql_native_password" {
+			t.Fatalf("unexpected plugin name, got %s", c.authPluginName)
+		}
+	})
+
+	t.Run("other plugin", func(t *testing.T) {
+		c := &Conn{}
+		c.SetCapability(mysql.CLIENT_PLUGIN_AUTH)
+		pos := 66
+
+		pos = c.readPluginName(otherPlugin, pos)
+		if pos != 73 {
+			t.Fatalf("unexpected pos, got %d", pos)
+		}
+
+		if c.authPluginName != "foobar" {
+			t.Fatalf("unexpected plugin name, got %s", c.authPluginName)
+		}
+	})
+
+	t.Run("mysql_native_password as default", func(t *testing.T) {
+		c := &Conn{}
+		pos := 123 // can be anything
+
+		pos = c.readPluginName(mysqlNativePassword, pos)
+		if pos != 123 {
+			t.Fatalf("unexpected pos, got %d", pos)
+		}
+
+		if c.authPluginName != mysql.AUTH_NATIVE_PASSWORD {
+			t.Fatalf("unexpected plugin name, got %s", c.authPluginName)
+		}
+	})
+}
+
 func TestReadAttributes(t *testing.T) {
 	var err error
 	// example data from