Merge branch 'master' into dterry/durablebinlogs

Author: dt8269

CHANGELOG.md

@@ -1,3 +1,22 @@
+### Tag v1.9.1 (2024-09-12)
+* Fix can't connect to MySQL 8.0 with long password. [#914](https://github.com/go-mysql-org/go-mysql/pull/914) ([lance6716](https://github.com/lance6716))
+* Fix actual master and add -race in CI. [#907](https://github.com/go-mysql-org/go-mysql/pull/907) ([atercattus](https://github.com/atercattus))
+* export EventCacheCount on Canal Config. [#913](https://github.com/go-mysql-org/go-mysql/pull/913) ([tomwei7](https://github.com/tomwei7))
+* FIX:The problem of the ignoreTables parameter not taking effect in the go-mysqldump package. [#910](https://github.com/go-mysql-org/go-mysql/pull/910) ([liuhuanxg](https://github.com/liuhuanxg))
+* fixing [email protected] errors of current build [#912](https://github.com/go-mysql-org/go-mysql/pull/) ([dvilaverde](https://github.com/dvilaverde))
+* Handle null index column names in sql.DB loader [#904](https://github.com/go-mysql-org/go-mysql/pull/) ([shauns](https://github.com/shauns))
+* Add DisableFlushBinlogWhileWaiting config and almost every query event triggers OnPosSynced [#900](https://github.com/go-mysql-org/go-mysql/pull/) ([morgo](https://github.com/morgo))
+* allow disabling the default golang database/sql retry behavior [#899](https://github.com/go-mysql-org/go-mysql/pull/) ([dvilaverde](https://github.com/dvilaverde))
+* fix(canal): do not ignore events with LogPos=0, use timestamp to distinguish fake rotate events [#894](https://github.com/go-mysql-org/go-mysql/pull/) ([mefcorvi](https://github.com/mefcorvi))
+* allow packet.Conn buffer size to be adjustable [#892](https://github.com/go-mysql-org/go-mysql/pull/) ([dvilaverde](https://github.com/dvilaverde))
+* time column type string formatting and test coverage [#891](https://github.com/go-mysql-org/go-mysql/pull/) ([jnewmano](https://github.com/jnewmano))
+* Support DSN without 'user:password@' [#888](https://github.com/go-mysql-org/go-mysql/pull/) ([dvilaverde](https://github.com/dvilaverde))
+* add support for driver.NamedValueChecker on driver connection [#887](https://github.com/go-mysql-org/go-mysql/pull/) ([dvilaverde](https://github.com/dvilaverde))
+* Additional Driver args for compression and connection read/write timeouts [#885](https://github.com/go-mysql-org/go-mysql/pull/) ([dvilaverde](https://github.com/dvilaverde))
+* reduce memory allocations when zlib compression is enabled [#880](https://github.com/go-mysql-org/go-mysql/pull/) ([dvilaverde](https://github.com/dvilaverde))
+* Fix no table is replicated when excludeTableRegex is set while includeTableRegex is nil [#874](https://github.com/go-mysql-org/go-mysql/pull/) ([gaojijun](https://github.com/gaojijun))
+* Make protocol version check more strict [#878](https://github.com/go-mysql-org/go-mysql/pull/) ([dveeden](https://github.com/dveeden))
+
 ### Tag v1.8.0 (2024-05-10)
 * Fix bug in handling sub events of replication.TransactionPayloadEvent. [#875](https://github.com/go-mysql-org/go-mysql/pull/875) ([froot](https://github.com/froot))
 * CI: Add tests for various MySQL versions. [#870](https://github.com/go-mysql-org/go-mysql/pull/870) ([dveeden](https://github.com/dveeden))

README.md

@@ -9,10 +9,10 @@ A pure go library to handle MySQL network protocol and replication.
 ## How to migrate to this repo
 To change the used package in your repo it's enough to add this `replace` directive to your `go.mod`:
 ```
-replace github.com/siddontang/go-mysql => github.com/go-mysql-org/go-mysql v1.8.0
+replace github.com/siddontang/go-mysql => github.com/go-mysql-org/go-mysql v1.9.0
 ```
 
-v1.8.0 - is the last tag in repo, feel free to choose what you want.
+v1.9.0 - is the last tag in repo, feel free to choose what you want.
 
 ## Changelog
 This repo uses [Changelog](CHANGELOG.md).

client/auth.go

@@ -115,11 +115,11 @@ func (c *Conn) readInitialHandshake() error {
 			// the first packet *must* have at least 20 bytes of a scramble.
 			// if a plugin provided less, we pad it to 20 with zeros
 			rest := int(authPluginDataLen) - 8
-			if max := 12 + 1; rest < max {
-				rest = max
+			if rest < 13 {
+				rest = 13
 			}
 
-			authPluginDataPart2 := data[pos : pos+rest]
+			authPluginDataPart2 := data[pos : pos+rest-1]
 			pos += rest
 
 			c.salt = append(c.salt, authPluginDataPart2...)

client/client_test.go

@@ -526,3 +526,16 @@ INSERT INTO field_value_test VALUES (
 		require.Equal(s.T(), expected[i], v.String())
 	}
 }
+
+func (s *clientTestSuite) TestLongPassword() {
+	_, err := s.c.Execute("DROP USER IF EXISTS 'test_long_password'@'%'")
+	require.NoError(s.T(), err)
+	_, err = s.c.Execute("CREATE USER 'test_long_password'@'%' IDENTIFIED BY '12345678901234567890'")
+	require.NoError(s.T(), err)
+
+	addr := fmt.Sprintf("%s:%s", *test_util.MysqlHost, s.port)
+	c, err := Connect(addr, "test_long_password", "12345678901234567890", "")
+	require.NoError(s.T(), err)
+	err = c.Close()
+	require.NoError(s.T(), err)
+}