binlogsyncer: Format config in logs

Author: dveeden

replication/binlogsyncer.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"crypto/tls"
 	"encoding/binary"
+	"encoding/json"
 	"fmt"
 	"net"
 	"os"
@@ -111,15 +112,15 @@ type BinlogSyncerConfig struct {
 
 	//Option function is used to set outside of BinlogSyncerConfig， between mysql connection and COM_REGISTER_SLAVE
 	//For MariaDB: slave_gtid_ignore_duplicates、skip_replication、slave_until_gtid
-	Option func(*client.Conn) error
+	Option func(*client.Conn) error `json:"-"`
 
 	// Set Logger
 	Logger loggers.Advanced
 
 	// Set Dialer
-	Dialer client.Dialer
+	Dialer client.Dialer `json:"-"`
 
-	RowsEventDecodeFunc func(*RowsEvent, []byte) error
+	RowsEventDecodeFunc func(*RowsEvent, []byte) error `json:"-"`
 
 	DiscardGTIDSet bool
 }
@@ -169,8 +170,14 @@ func NewBinlogSyncer(cfg BinlogSyncerConfig) *BinlogSyncer {
 
 	// Clear the Password to avoid outputing it in log.
 	pass := cfg.Password
-	cfg.Password = ""
-	cfg.Logger.Infof("create BinlogSyncer with config %v", cfg)
+	cfg.Password = "<hidden>"
+	jsonCfg, err := json.Marshal(cfg)
+	if err != nil {
+		cfg.Logger.Warnf("Failed to encode config as JSON: %s", err)
+		cfg.Logger.Infof("create BinlogSyncer with config %#v", cfg)
+	}
+	cfg.Logger.Infof("create BinlogSyncer with config %s", jsonCfg)
+
 	cfg.Password = pass
 
 	b := new(BinlogSyncer)