Dump.go Log.infof the args

[nxjkho]

https://github.com/siddontang/go-mysql/blob/master/dump/dump.go#L203

args = append(args, fmt.Sprintf("--user=%s", d.User))
args = append(args, fmt.Sprintf("--password=%s", d.Password))

log.Infof("exec mysqldump with %v", args)
would this also send the credentials to the log?

Seem dangerous

[nxjkho]

follow up on this. @siddontang
I can do a pull request for this to comment the log.info out

[Christian-Lemieux]

@siddontang Seconding this as well. I'd prefer to avoid having production DB username/passwords logged in plaintext. Would it be cool to open a PR to add an optional flag to disable this?