Skip to content

Run test also on mysql 8.x #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atercattus opened this issue Apr 8, 2021 · 4 comments · Fixed by #527
Closed

Run test also on mysql 8.x #565

atercattus opened this issue Apr 8, 2021 · 4 comments · Fixed by #527
Labels
enhancement

Comments

@atercattus
Copy link
Member

Current GitHub action .yml uses ubuntu-18.04 with mysql 5.7.

It would be good to test the package also on mysql 8.x.
@atercattus atercattus linked a pull request Apr 20, 2021 that will close this issue
Fix fetchIndexesViaSqlDB/NewTableFromSqlDB for MySQL 8.0 #527
Merged
@atercattus
Copy link
Member Author

Hmm. But we haven't changed our .github/workflows/ci.yml for newer MySQL versions.

And #527 it's only one fix for this.

@atercattus atercattus reopened this Jan 9, 2022
@dveeden
Copy link
Collaborator

dveeden commented Nov 7, 2024 •
edited
Loading

https://github.com/go-mysql-org/go-mysql/blob/master/.github/workflows/ci.yml

  • Looks like test is using the MySQL that comes with the OS.
  • And mysqltest has a matrix with currently 8.0.37 and 8.4.0

This seems good enough for me. @atercattus @lance6716 can we close this?

@lance6716
Copy link
Collaborator

I think 8.x tests are covered, wait for @atercattus 's opinion

@dveeden
Copy link
Collaborator

dveeden commented Mar 10, 2025

I think we now run full tests on MySQL 8.0/8.4 so we can probably close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fetchIndexesViaSqlDB/NewTableFromSqlDB for MySQL 8.0 RobinGeuze/go-mysql
3 participants
@atercattus @dveeden @lance6716