Skip to content

Is this code supposed to work? #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viciious opened this issue Jun 27, 2022 · 3 comments · Fixed by #706
Closed

Is this code supposed to work? #705

viciious opened this issue Jun 27, 2022 · 3 comments · Fixed by #706

Comments

@viciious
Copy link
Contributor

https://github.com/go-mysql-org/go-mysql/blob/master/client/conn.go#L87

c.tlsConfig can't be anything but nil at that point since the options array hasn't been applied to the connection yet

@lance6716
Copy link
Collaborator

You are right 😭 would you like to fix it?

@viciious
Copy link
Contributor Author

viciious commented Jun 27, 2022

Sure, but what would you suggest as the best approach? I suppose someone may rely on c.Conn being non-nil before the options are applied in order to set the initial Sequence.

@viciious
Copy link
Contributor Author

Something like this maybe? #706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants