-
Notifications
You must be signed in to change notification settings - Fork 1k
Update Go version #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
go 1.21 introduced |
My personal preference is to use the standard library where possible, and slog would match that. However I don't know what @atercattus and @lance6716 think of that. |
I also prefer the standard library. For compatibility problem, I think the developers won't be bothered much if the new logger can be configurated easily, or we provide a converter function, or we release a major version which means API break. |
In
go.mod
we have the version set to 1.18The Go release policy is "Each major Go release is supported until there are two newer major releases.". This means only 1.23 and 1.22 are in support.
https://go.dev/doc/devel/release#:~:text=Each%20major%20Go%20release%20is%20supported%20until%20there%20are%20two%20newer%20major%20releases.
Not sure how this would impact projects depending on go-mysql.
Not sure if there are any real benefits to bumping the version either.
If we bump the version, should we go to 1.21, 1.22? or 1.23?
@lance6716 @atercattus what do you think?
The text was updated successfully, but these errors were encountered: