From e1c04520cbff3fb7eceb22fc10f02c4b3471c107 Mon Sep 17 00:00:00 2001 From: atercattus Date: Sat, 28 Jan 2023 12:23:26 +0400 Subject: [PATCH] replication - just return an error not logging it --- replication/row_event.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/replication/row_event.go b/replication/row_event.go index 8c02e1685..fa3c05268 100644 --- a/replication/row_event.go +++ b/replication/row_event.go @@ -11,7 +11,6 @@ import ( "github.com/pingcap/errors" "github.com/shopspring/decimal" - "github.com/siddontang/go-log/log" "github.com/siddontang/go/hack" . "github.com/go-mysql-org/go-mysql/mysql" @@ -906,9 +905,7 @@ func (e *RowsEvent) DecodeData(pos int, data []byte) (err2 error) { // ... repeat rows until event-end defer func() { if r := recover(); r != nil { - errStr := fmt.Sprintf("parse rows event panic %v, data %q, parsed rows %#v, table map %#v", r, data, e, e.Table) - log.Errorf("%s\n%s", errStr, Pstack()) - err2 = errors.Trace(errors.New(errStr)) + err2 = errors.Errorf("parse rows event panic %v, data %q, parsed rows %#v, table map %#v", r, data, e, e.Table) } }()