Handle IndexOutOfBoundsException when container hasn't been brought up.

* The pod status will be pending and this can be viewed in the agent status report now.

Author: varshavaradarajan

Diff for: src/main/java/cd/go/contrib/elasticagent/executors/AgentStatusReportExecutor.java

@@ -47,7 +47,7 @@ public AgentStatusReportExecutor(AgentStatusReportRequest request, PluginRequest
         this(request, pluginRequest, KubernetesClientFactory.instance(), PluginStatusReportViewBuilder.instance());
     }
 
-    public AgentStatusReportExecutor(AgentStatusReportRequest request, PluginRequest pluginRequest, KubernetesClientFactory kubernetesClientFactory, PluginStatusReportViewBuilder builder) {
+    AgentStatusReportExecutor(AgentStatusReportRequest request, PluginRequest pluginRequest, KubernetesClientFactory kubernetesClientFactory, PluginStatusReportViewBuilder builder) {
         this.request = request;
         this.pluginRequest = pluginRequest;
         this.factory = kubernetesClientFactory;

Diff for: src/main/java/cd/go/contrib/elasticagent/model/reports/agent/GoCDContainerDetails.java

@@ -31,9 +31,14 @@ public static GoCDContainerDetails fromContainer(Container container, ContainerS
         for (EnvVar var : container.getEnv()) {
             containerDetails.env.add(new EnvironmentVariable(var.getName(), var.getValue()));
         }
-
-        containerDetails.ready = containerStatus.getReady();
-        containerDetails.restartCount = containerStatus.getRestartCount();
+        if (containerStatus != null) {
+            containerDetails.ready = containerStatus.getReady();
+            containerDetails.restartCount = containerStatus.getRestartCount();
+        }
+        else {
+            containerDetails.ready = false;
+            containerDetails.restartCount = 0;
+        }
 
         return containerDetails;
     }

Diff for: src/main/java/cd/go/contrib/elasticagent/model/reports/agent/KubernetesElasticAgent.java

@@ -21,11 +21,13 @@
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
+import io.fabric8.kubernetes.api.model.ContainerStatus;
 import io.fabric8.kubernetes.api.model.Event;
 import io.fabric8.kubernetes.api.model.Pod;
 import io.fabric8.kubernetes.client.KubernetesClient;
 
 import java.util.ArrayList;
+import java.util.List;
 
 public class KubernetesElasticAgent {
     private JobIdentifier jobIdentifier;
@@ -41,7 +43,9 @@ public static KubernetesElasticAgent fromPod(KubernetesClient client, Pod pod, J
         agent.jobIdentifier = getJobIdentifier(pod, jobIdentifier);
         agent.elasticAgentId = pod.getMetadata().getName();
         agent.podDetails = KubernetesPodDetails.fromPod(pod);
-        agent.agentDetails = GoCDContainerDetails.fromContainer(pod.getSpec().getContainers().get(0), pod.getStatus().getContainerStatuses().get(0));
+        List<ContainerStatus> containerStatuses = pod.getStatus().getContainerStatuses();
+        ContainerStatus containerStatus = containerStatuses.isEmpty() ? null : containerStatuses.get(0);
+        agent.agentDetails = GoCDContainerDetails.fromContainer(pod.getSpec().getContainers().get(0), containerStatus);
         agent.events = getAllEventsForPod(pod, client);
         agent.logs = getPodLogs(pod, client);
         agent.configuration = getPodConfiguration(pod);

Diff for: src/test/java/cd/go/contrib/elasticagent/executors/AgentStatusReportExecutorTest.java

@@ -50,7 +50,6 @@
 
 public class AgentStatusReportExecutorTest {
 
-    private Pod pod;
     private AgentStatusReportExecutor executor;
     private String elasticAgentId = "elastic-agent-id";
 
@@ -93,7 +92,7 @@ public class AgentStatusReportExecutorTest {
     @Before
     public void setUp() {
         initMocks(this);
-        pod = createDefaultPod();
+        Pod pod = createDefaultPod();
         pod.getMetadata().setName(elasticAgentId);
         executor = new AgentStatusReportExecutor(statusReportRequest, pluginRequest, kubernetesClientFactory, builder);