code review

Author: CC11001100

README.md

@@ -31,7 +31,7 @@ func main() {
 	wg.Add(1)
 	go func() {
 		defer wg.Done()
-		goroutineId, err = goroutine_id.GetGoroutineID()
+		goroutineId, err = goroutine_id.GetGoroutineId()
 		if err != nil {
 			panic(err)
 		}
@@ -42,7 +42,7 @@ func main() {
 	// Goroutine ID: 6
 
 	// Look at the id of the main coroutine
-	goroutineId, err = goroutine_id.GetGoroutineID()
+	goroutineId, err = goroutine_id.GetGoroutineId()
 	if err != nil {
 		panic(err)
 	}

errors.go

@@ -0,0 +1,8 @@
+package goroutine_id
+
+import "errors"
+
+var (
+	// ErrGetGoroutineIdFailed 获取goroutine id失败
+	ErrGetGoroutineIdFailed = errors.New("get goroutine id failed")
+)

examples/main.go

@@ -16,7 +16,7 @@ func main() {
 	wg.Add(1)
 	go func() {
 		defer wg.Done()
-		goroutineId, err = goroutine_id.GetGoroutineID()
+		goroutineId, err = goroutine_id.GetGoroutineId()
 		if err != nil {
 			panic(err)
 		}
@@ -27,7 +27,7 @@ func main() {
 	// Goroutine ID: 6
 
 	// Look at the id of the main coroutine
-	goroutineId, err = goroutine_id.GetGoroutineID()
+	goroutineId, err = goroutine_id.GetGoroutineId()
 	if err != nil {
 		panic(err)
 	}

goroutine_id_stack_based.go

@@ -9,21 +9,30 @@ import (
 
 // ------------------------------------------------- --------------------------------------------------------------------
 
-// GetGoroutineID 获取当前协程的ID
-func GetGoroutineID() (int, error) {
-	id, err := strconv.Atoi(GetGoroutineIDAsString())
+// GetGoroutineId 获取当前协程的id
+func GetGoroutineId() (int, error) {
+
+	goroutineIdString := GetGoroutineIdAsString()
+	if goroutineIdString == "" {
+		return 0, ErrGetGoroutineIdFailed
+	}
+
+	goroutineId, err := strconv.Atoi(goroutineIdString)
 	if err != nil {
-		return 0, fmt.Errorf("cannot get goroutine id: %v", err)
+		return 0, fmt.Errorf("goroutine goroutineId parse int error, value = %s, msg = %s", goroutineIdString, err.Error())
 	}
-	return id, nil
+	return goroutineId, nil
 }
 
-// GetGoroutineIDAsString 获取当前协程的ID，以字符串的形式返回
-func GetGoroutineIDAsString() string {
+// GetGoroutineIdAsString 获取当前协程的id，以字符串的形式返回
+func GetGoroutineIdAsString() string {
 	var buf [64]byte
 	n := runtime.Stack(buf[:], false)
-	idField := strings.Fields(strings.TrimPrefix(string(buf[:n]), "goroutine "))[0]
-	return idField
+	fields := strings.Fields(strings.TrimPrefix(string(buf[:n]), "goroutine "))
+	if len(fields) < 1 {
+		return ""
+	}
+	return fields[0]
 }
 
 // ------------------------------------------------- --------------------------------------------------------------------

goroutine_id_stack_based_test.go

@@ -14,7 +14,7 @@ func TestGetGoroutineID(t *testing.T) {
 	wg.Add(1)
 	go func() {
 		defer wg.Done()
-		goroutineId, _ = GetGoroutineID()
+		goroutineId, _ = GetGoroutineId()
 	}()
 	wg.Wait()