Skip to content

Commit 14add1f

Browse files
thanmheschi
authored andcommitted
internal/releasetargets: use *-oldcc windows 386/amd64 builders for 1.18/1.19
Select the *-oldcc variants for windows 386/amd64 builders for when building 1.18/1.19 minor releases. This syncs up relui with similar changes in the dashboard (e.g. CL 453095). For golang/go#35006. Change-Id: I1df3fef9459ca23593571448129eb1d1497c4529 Reviewed-on: https://go-review.googlesource.com/c/build/+/454098 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Than McIntosh <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
1 parent 98eb568 commit 14add1f

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

internal/releasetargets/releases.txt

+6-6
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ linux-s390x linux s390x linux-s390x-crosscompile
3838
Build only
3939
Running on GCP
4040

41-
windows-386 windows 386 windows-386-2008
41+
windows-386 windows 386 windows-386-2008-oldcc
4242
Running on GCP
4343

44-
windows-amd64 windows amd64 windows-amd64-2008
45-
Race enabled, Long tests on windows-amd64-longtest
44+
windows-amd64 windows amd64 windows-amd64-2008-oldcc
45+
Race enabled, Long tests on windows-amd64-longtest-oldcc
4646
Running on GCP
4747

4848
windows-arm64 windows arm64 windows-arm64-11
@@ -90,11 +90,11 @@ linux-s390x linux s390x linux-s390x-crosscompile
9090
Build only
9191
Running on GCP
9292

93-
windows-386 windows 386 windows-386-2008
93+
windows-386 windows 386 windows-386-2008-oldcc
9494
Running on GCP
9595

96-
windows-amd64 windows amd64 windows-amd64-2008
97-
Race enabled, Long tests on windows-amd64-longtest
96+
windows-amd64 windows amd64 windows-amd64-2008-oldcc
97+
Race enabled, Long tests on windows-amd64-longtest-oldcc
9898
Running on GCP
9999

100100
windows-arm64 windows arm64 windows-arm64-11

internal/releasetargets/releasetargets.go

+7-3
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,13 @@ var allReleases = map[int]ReleaseTargets{
9494
Builder: "linux-ppc64le-buildlet",
9595
BuildOnly: true,
9696
},
97+
// *-oldcc amd64/386 builders needed for 1.18, 1.19
9798
"windows-386": &Target{
98-
Builder: "windows-386-2008",
99+
Builder: "windows-386-2008-oldcc",
99100
},
100101
"windows-amd64": &Target{
101-
Builder: "windows-amd64-2008",
102-
LongTestBuilder: "windows-amd64-longtest",
102+
Builder: "windows-amd64-2008-oldcc",
103+
LongTestBuilder: "windows-amd64-longtest-oldcc",
103104
Race: true,
104105
},
105106
"windows-arm64": &Target{
@@ -139,6 +140,9 @@ var allReleases = map[int]ReleaseTargets{
139140
Builder: "linux-amd64-bullseye",
140141
LongTestBuilder: "linux-amd64-longtest",
141142
},
143+
"windows-386": &Target{
144+
Builder: "windows-386-2008",
145+
},
142146
"windows-amd64": &Target{
143147
Builder: "windows-amd64-2008",
144148
LongTestBuilder: "windows-amd64-longtest",

0 commit comments

Comments
 (0)