Skip to content

Commit 5d7d900

Browse files
committed
dashboard: reenable linux-amd64-alpine
It passes all.bash in the main repo after CL 419995. For golang/go#19938. Change-Id: I03c32193bbc83667e7bbbb2251e15a4a9bef6cfc Reviewed-on: https://go-review.googlesource.com/c/build/+/420214 Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Russ Cox <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent a829e57 commit 5d7d900

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

dashboard/builders.go

+4-8
Original file line numberDiff line numberDiff line change
@@ -1591,14 +1591,10 @@ func init() {
15911591
HostType: "host-linux-amd64-stretch-vmx",
15921592
buildsRepo: disabledBuilder,
15931593
})
1594-
1595-
const testAlpine = false // Issue 22689 (hide all red builders), Issue 19938 (get Alpine passing)
1596-
if testAlpine {
1597-
addBuilder(BuildConfig{
1598-
Name: "linux-amd64-alpine",
1599-
HostType: "host-linux-amd64-alpine",
1600-
})
1601-
}
1594+
addBuilder(BuildConfig{
1595+
Name: "linux-amd64-alpine",
1596+
HostType: "host-linux-amd64-alpine",
1597+
})
16021598

16031599
// addMiscCompileGo1 adds a misc-compile TryBot that
16041600
// runs buildall.bash on the specified target(s), up to 3 max.

dashboard/builders_test.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -669,9 +669,7 @@ func TestBuilderConfig(t *testing.T) {
669669
}
670670

671671
func TestHostConfigsAllUsed(t *testing.T) {
672-
knownUnused := map[string]bool{
673-
"host-linux-amd64-alpine": true, // TODO(golang.org/issue/19938): Fix the Alpine builder, or remove it.
674-
}
672+
knownUnused := map[string]bool{}
675673

676674
used := make(map[string]bool)
677675
for _, conf := range Builders {

0 commit comments

Comments
 (0)