Skip to content

Commit 808d0cd

Browse files
committed
dashboard, cmd/gomote: remove the linux-386-387 builder
The linux-386-387 was only in use for Go 1.15 development. It is being removed as there is no further development for Go 1.15. For golang/go#40255 For golang/go#41799 Change-Id: If636c0099bce195e227a5036842ace92e8305fc9 Reviewed-on: https://go-review.googlesource.com/c/build/+/342895 Trust: Carlos Amedee <[email protected]> Run-TryBot: Carlos Amedee <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent 6a8cf83 commit 808d0cd

File tree

3 files changed

+1
-18
lines changed

3 files changed

+1
-18
lines changed

cmd/gomote/gomote.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ The "gomote run" command has many of its own flags:
5050
-builderenv string
5151
Optional alternate builder to act like. Must share the same
5252
underlying buildlet host type, or it's an error. For
53-
instance, linux-amd64-race or linux-386-387 are compatible
53+
instance, linux-amd64-race is compatible
5454
with linux-amd64, but openbsd-amd64 and openbsd-386 are
5555
different hosts.
5656
-debug

dashboard/builders.go

-11
Original file line numberDiff line numberDiff line change
@@ -1548,17 +1548,6 @@ func init() {
15481548
HostType: "host-linux-stretch",
15491549
env: []string{"GOARCH=386", "GOHOSTARCH=386", "GO386=softfloat"},
15501550
})
1551-
addBuilder(BuildConfig{
1552-
Name: "linux-386-387",
1553-
Notes: "GO386=387",
1554-
buildsRepo: func(repo, branch, goBranch string) bool {
1555-
// GO386=387 is removed in Go 1.16 (golang.org/issue/40255).
1556-
// It's still supported in Go 1.15.
1557-
return atMostGo1(goBranch, 15) && (repo == "go" || repo == "crypto")
1558-
},
1559-
HostType: "host-linux-jessie",
1560-
env: []string{"GOARCH=386", "GOHOSTARCH=386", "GO386=387"},
1561-
})
15621551
addBuilder(BuildConfig{
15631552
Name: "linux-amd64",
15641553
HostType: "host-linux-stretch",

dashboard/builders_test.go

-6
Original file line numberDiff line numberDiff line change
@@ -372,12 +372,6 @@ func TestBuilderConfig(t *testing.T) {
372372
{b("linux-386-softfloat", "crypto"), onlyPost},
373373
{b("[email protected]", "crypto"), onlyPost},
374374
{b("[email protected]", "crypto"), none},
375-
{b("linux-386-387", "crypto"), none},
376-
{b("[email protected]", "crypto"), none},
377-
{b("[email protected]", "crypto"), onlyPost},
378-
379-
{b("[email protected]", "build"), none},
380-
{b("[email protected]", "crypto"), onlyPost},
381375
{b("[email protected]", "net"), none},
382376
{b("linux-arm-arm5spacemonkey", "exp"), none},
383377
{b("linux-arm-arm5spacemonkey", "mobile"), none},

0 commit comments

Comments
 (0)