Skip to content

Commit e37005b

Browse files
committed
dashboard: add a make.bash-only builder on real ARM hardware
This is a new builder in prep for the change to the "linux-arm" builder where the GOARCH=arm make.bash will be cross-compiled from a Kubernetes container on fast hardware. Updates golang/go#17105 (cross-compile ARM builders' make.bash) Updates golang/go#17104 (5 minute trybots) Change-Id: Icfd2644d77639f731151abe54839322960418254 Reviewed-on: https://go-review.googlesource.com/29670 Reviewed-by: Matthew Dempsky <[email protected]>
1 parent 5566fc6 commit e37005b

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

cmd/coordinator/coordinator.go

+3
Original file line numberDiff line numberDiff line change
@@ -1538,6 +1538,9 @@ func (st *buildStatus) runAllSharded() (remoteErr, err error) {
15381538
if remoteErr != nil {
15391539
return fmt.Errorf("build failed: %v", remoteErr), nil
15401540
}
1541+
if st.conf.StopAfterMake {
1542+
return nil, nil
1543+
}
15411544

15421545
if err := st.doSnapshot(); err != nil {
15431546
return nil, err

dashboard/builders.go

+14
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,14 @@ type BuildConfig struct {
275275
CompileOnly bool // if true, compile tests, but don't run them
276276
FlakyNet bool // network tests are flaky (try anyway, but ignore some failures)
277277

278+
// StopAfterMake causes the build to stop after the make
279+
// script completes, returning its result as the result of the
280+
// whole build. It does not run or compile any of the tests,
281+
// nor does it write a snapshot of the world to cloud
282+
// storage. This option is only supported for builders whose
283+
// BuildConfig.SplitMakeRun returns true.
284+
StopAfterMake bool
285+
278286
// numTestHelpers is the number of _additional_ buildlets
279287
// past the first one to help out with sharded tests.
280288
// For trybots, the numTryHelpers value is used, unless it's
@@ -628,6 +636,12 @@ func init() {
628636
numTestHelpers: 2,
629637
numTryTestHelpers: 7,
630638
})
639+
addBuilder(BuildConfig{
640+
Name: "linux-arm-nativemake",
641+
Notes: "runs make.bash on real ARM hardware, but does not run tests",
642+
HostType: "host-linux-arm",
643+
StopAfterMake: true,
644+
})
631645
addBuilder(BuildConfig{
632646
Name: "linux-arm-arm5",
633647
HostType: "host-linux-arm",

0 commit comments

Comments
 (0)