Skip to content

Commit fdfb99e

Browse files
committed
env/darwin/aws: reduce guest CPU count to 4
QEMU scales poorly with CPU count on macOS (see https://go.dev/issue/48945#issuecomment-1378850381). Reducing the CPU count from 6 to 4 reduces boot time from ~4min to ~1min40sec. For golang/go#48945. Change-Id: I63fa70938049534b8f87d30935179d99a2e8f2f6 Reviewed-on: https://go-review.googlesource.com/c/build/+/461775 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Run-TryBot: Michael Pratt <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent f4053b6 commit fdfb99e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

env/darwin/aws/qemu.sh

+4-3
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,10 @@ args=(
2323
-cpu host
2424
-machine q35
2525
-usb -device usb-kbd -device usb-tablet
26-
# macOS only likes a power-of-two number of cores, but odd socket count is
27-
# fine.
28-
-smp cpus=6,sockets=3,cores=2,threads=1
26+
# QEMU scales poorly with CPU count on macOS (see
27+
# https://go.dev/issue/48945#issuecomment-1378850381). Increasing CPU count
28+
# also increases boot time.
29+
-smp cpus=4
2930
-device usb-ehci,id=ehci
3031
-device nec-usb-xhci,id=xhci
3132
-global nec-usb-xhci.msi=off

0 commit comments

Comments
 (0)