Skip to content

Commit 1bf973d

Browse files
authored
tests: Remove outdated flaky test comments (#147)
Remove TODO from tests that are no longer flaky. (Tested 1k times, see #120 (comment))
1 parent 07d601f commit 1bf973d

5 files changed

+0
-15
lines changed

s2/convex_hull_query_test.go

-3
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,6 @@ func TestConvexHullQueryLoopsAroundNorthPole(t *testing.T) {
193193
}
194194

195195
func TestConvexHullQueryPointsInsideHull(t *testing.T) {
196-
// TODO: Verify if it's still about 0.3% flaky with a random seed.
197-
// TODO(rsned): https://github.com/golang/geo/issues/120
198-
199196
// Repeatedly build the convex hull of a set of points, then add more points
200197
// inside that loop and build the convex hull again. The result should
201198
// always be the same.

s2/edge_clipping_test.go

-3
Original file line numberDiff line numberDiff line change
@@ -247,9 +247,6 @@ func testClipToPaddedFace(t *testing.T, a, b Point) {
247247
}
248248

249249
func TestEdgeClippingClipToPaddedFace(t *testing.T) {
250-
// TODO: Verify if it's still about 1.2% flaky with a random seed.
251-
// TODO(rsned): https://github.com/golang/geo/issues/120
252-
253250
// Start with a few simple cases.
254251
// An edge that is entirely contained within one cube face:
255252
testClipToPaddedFace(t, Point{r3.Vector{X: 1, Y: -0.5, Z: -0.5}}, Point{r3.Vector{X: 1, Y: 0.5, Z: 0.5}})

s2/paddedcell_test.go

-3
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,6 @@ func TestPaddedCellEntryExitVertices(t *testing.T) {
132132
}
133133

134134
func TestPaddedCellShrinkToFit(t *testing.T) {
135-
// TODO: Verify if it's still about 0.2% flaky with a random seed.
136-
// TODO(rsned): https://github.com/golang/geo/issues/120
137-
138135
for iter := 0; iter < 1000; iter++ {
139136
// Start with the desired result and work backwards.
140137
result := randomCellID()

s2/point_test.go

-3
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,6 @@ func TestPointDistance(t *testing.T) {
100100
}
101101

102102
func TestChordAngleBetweenPoints(t *testing.T) {
103-
// TODO: Verify if it's still about 0.2% flaky with a random seed.
104-
// TODO(rsned): https://github.com/golang/geo/issues/120
105-
106103
for iter := 0; iter < 100; iter++ {
107104
m := randomFrame()
108105
x := m.col(0)

s2/s2_test_test.go

-3
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ func numVerticesAtLevel(level int) int {
5050
}
5151

5252
func TestTestingFractal(t *testing.T) {
53-
// TODO: Verify if it's about 2.4% flaky with a random seed, due to CesaroMultiFractal.
54-
// TODO(rsned): https://github.com/golang/geo/issues/120
55-
5653
tests := []struct {
5754
label string
5855
minLevel int

0 commit comments

Comments
 (0)