Skip to content

Commit 1011cca

Browse files
dmitshurgopherbot
authored andcommitted
cmd/dist: mark linux/sparc64 as a broken port, remove incomplete map
The linux/sparc64 port is incomplete—it doesn't work, and it doesn't have a builder. Now that dist supports broken ports, mark it as such. The incomplete map was created to hide ports that aren't functional from dist list output. Now that we have the broken port concept, it seems largely redundant, so remove it for now. For #56679. Updates #28944. Change-Id: I34bd23e913ed6d786a4d0aa8d2852f2b926fe4b6 Reviewed-on: https://go-review.googlesource.com/c/go/+/458516 Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent 399ad79 commit 1011cca

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

src/cmd/dist/build.go

+4-8
Original file line numberDiff line numberDiff line change
@@ -1681,17 +1681,13 @@ var cgoEnabled = map[string]bool{
16811681
"windows/arm64": true,
16821682
}
16831683

1684-
// List of platforms which are supported but not complete yet. These get
1685-
// filtered out of cgoEnabled for 'dist list'. See go.dev/issue/28944.
1686-
var incomplete = map[string]bool{
1687-
"linux/sparc64": true,
1688-
}
1689-
16901684
// List of platforms that are marked as broken ports.
16911685
// These require -force flag to build, and also
16921686
// get filtered out of cgoEnabled for 'dist list'.
16931687
// See go.dev/issue/56679.
1694-
var broken = map[string]bool{}
1688+
var broken = map[string]bool{
1689+
"linux/sparc64": true, // An incomplete port. See CL 132155.
1690+
}
16951691

16961692
// List of platforms which are first class ports. See go.dev/issue/38874.
16971693
var firstClass = map[string]bool{
@@ -1839,7 +1835,7 @@ func cmdlist() {
18391835

18401836
var plats []string
18411837
for p := range cgoEnabled {
1842-
if broken[p] || incomplete[p] {
1838+
if broken[p] {
18431839
continue
18441840
}
18451841
plats = append(plats, p)

src/cmd/dist/test.go

-6
Original file line numberDiff line numberDiff line change
@@ -265,12 +265,6 @@ func (t *tester) run() {
265265
if t.failed {
266266
fmt.Println("\nFAILED")
267267
xexit(1)
268-
} else if incomplete[goos+"/"+goarch] {
269-
// The test succeeded, but consider it as failed so we don't
270-
// forget to remove the port from the incomplete map once the
271-
// port is complete.
272-
fmt.Println("\nFAILED (incomplete port)")
273-
xexit(1)
274268
} else if t.partial {
275269
fmt.Println("\nALL TESTS PASSED (some were excluded)")
276270
} else {

0 commit comments

Comments
 (0)