Skip to content

Commit 3419a0a

Browse files
panjf2000gopherbot
authored andcommitted
encoding/json: use base64.Encoding.AppendEncode
For #53693 Change-Id: I6a428a4a10a2e2efa03296f539e190f0743c1f46 Reviewed-on: https://go-review.googlesource.com/c/go/+/520755 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Joseph Tsai <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Run-TryBot: Andy Pan <[email protected]>
1 parent ce16086 commit 3419a0a

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/encoding/json/encode.go

+2-6
Original file line numberDiff line numberDiff line change
@@ -781,15 +781,11 @@ func encodeByteSlice(e *encodeState, v reflect.Value, _ encOpts) {
781781
e.WriteString("null")
782782
return
783783
}
784-
s := v.Bytes()
785-
encodedLen := base64.StdEncoding.EncodedLen(len(s))
786-
e.Grow(len(`"`) + encodedLen + len(`"`))
787784

788-
// TODO(https://go.dev/issue/53693): Use base64.Encoding.AppendEncode.
785+
s := v.Bytes()
789786
b := e.AvailableBuffer()
790787
b = append(b, '"')
791-
base64.StdEncoding.Encode(b[len(b):][:encodedLen], s)
792-
b = b[:len(b)+encodedLen]
788+
b = base64.StdEncoding.AppendEncode(b, s)
793789
b = append(b, '"')
794790
e.Write(b)
795791
}

0 commit comments

Comments
 (0)