Skip to content

Commit 3f2bf70

Browse files
prattmicgopherbot
authored andcommitted
runtime/metrics: document runtime-internal locks in /sync/mutex/wait/total:seconds
For #57071. Change-Id: I7ce6c35bed95a6ea3cdc17007f861c5dd82404d2 Reviewed-on: https://go-review.googlesource.com/c/go/+/547056 Auto-Submit: Michael Pratt <[email protected]> Reviewed-by: Rhys Hiltner <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 98fd8f5 commit 3f2bf70

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

Diff for: src/runtime/metrics/description.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ var allDesc = []Description{
441441
},
442442
{
443443
Name: "/sync/mutex/wait/total:seconds",
444-
Description: "Approximate cumulative time goroutines have spent blocked on a sync.Mutex or sync.RWMutex. This metric is useful for identifying global changes in lock contention. Collect a mutex or block profile using the runtime/pprof package for more detailed contention data.",
444+
Description: "Approximate cumulative time goroutines have spent blocked on a sync.Mutex, sync.RWMutex, or runtime-internal lock. This metric is useful for identifying global changes in lock contention. Collect a mutex or block profile using the runtime/pprof package for more detailed contention data.",
445445
Kind: KindFloat64,
446446
Cumulative: true,
447447
},

Diff for: src/runtime/metrics/doc.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -447,10 +447,10 @@ Below is the full list of supported metrics, ordered lexicographically.
447447
monotonically.
448448
449449
/sync/mutex/wait/total:seconds
450-
Approximate cumulative time goroutines have spent blocked
451-
on a sync.Mutex or sync.RWMutex. This metric is useful for
452-
identifying global changes in lock contention. Collect a mutex
453-
or block profile using the runtime/pprof package for more
454-
detailed contention data.
450+
Approximate cumulative time goroutines have spent blocked on a
451+
sync.Mutex, sync.RWMutex, or runtime-internal lock. This metric
452+
is useful for identifying global changes in lock contention.
453+
Collect a mutex or block profile using the runtime/pprof package
454+
for more detailed contention data.
455455
*/
456456
package metrics

0 commit comments

Comments
 (0)