Skip to content

Commit 40657c2

Browse files
committed
runtime: fix s390x build
The new prototypes of duffzero and duffcopy must be accompanied by functions. Otherwise buildmode=shared (in particular, misc/cgo/testshared) has missing symbols. The right fix, of course, is to implement these on s390x. For #31916. Change-Id: I3efff5e3011956341e1b26223a4847a8a91a0453 Reviewed-on: https://go-review.googlesource.com/c/go/+/176397 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent b8d5150 commit 40657c2

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

src/runtime/duff_s390x.s

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
// Copyright 2019 The Go Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style
3+
// license that can be found in the LICENSE file.
4+
5+
#include "go_asm.h"
6+
#include "go_tls.h"
7+
#include "textflag.h"
8+
9+
// s390x can copy/zero 1-256 bytes with a single instruction,
10+
// so there's no need for these, except to satisfy the prototypes
11+
// in stubs.go.
12+
13+
TEXT runtime·duffzero(SB),NOSPLIT|NOFRAME,$0-0
14+
MOVD $0, 2(R0)
15+
RET
16+
17+
TEXT runtime·duffcopy(SB),NOSPLIT|NOFRAME,$0-0
18+
MOVD $0, 2(R0)
19+
RET

0 commit comments

Comments
 (0)