Skip to content

Commit 4a70ff4

Browse files
author
Bryan C. Mills
committed
cmd/go/internal/renameio: skip test affected by kernel bug on macOS 10.14 builders
The test will remain flaky on the -nocgo builder until #37695 is addressed. Updates #37695 Fixes #33041 Change-Id: I5d661ef39e82ab1dce3a76e0e4059cf556135e89 Reviewed-on: https://go-review.googlesource.com/c/go/+/222158 Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Jay Conrod <[email protected]>
1 parent 55d4cbf commit 4a70ff4

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/cmd/go/internal/renameio/renameio_test.go

+6
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@ package renameio
99
import (
1010
"encoding/binary"
1111
"errors"
12+
"internal/testenv"
1213
"io/ioutil"
1314
"math/rand"
1415
"os"
1516
"path/filepath"
1617
"runtime"
18+
"strings"
1719
"sync"
1820
"sync/atomic"
1921
"syscall"
@@ -24,6 +26,10 @@ import (
2426
)
2527

2628
func TestConcurrentReadsAndWrites(t *testing.T) {
29+
if runtime.GOOS == "darwin" && strings.HasSuffix(testenv.Builder(), "-10_14") {
30+
testenv.SkipFlaky(t, 33041)
31+
}
32+
2733
dir, err := ioutil.TempDir("", "renameio")
2834
if err != nil {
2935
t.Fatal(err)

0 commit comments

Comments
 (0)