Skip to content

Commit 52d5e76

Browse files
committed
runtime: disable async preemption on darwin/arm(64) for now
Enabling async preemption on darwin/arm and darwin/arm64 causes the builder to fail, e.g. https://build.golang.org/log/03f727b8f91b0c75bf54ff508d7d2f00b5cad4bf Due to the limited resource, I haven't been able to get access on those devices to debug. Disable async preemption for now. Updates #35439. Change-Id: I5a31ad6962c2bae8e6e9b8303c494610a8a4e50a Reviewed-on: https://go-review.googlesource.com/c/go/+/205842 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 953cc74 commit 52d5e76

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/runtime/signal_arm.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ func (c *sigctxt) preparePanic(sig uint32, gp *g) {
6363
c.set_pc(uint32(funcPC(sigpanic)))
6464
}
6565

66-
const pushCallSupported = true
66+
// TODO(issue 35439): enabling async preemption causes failures on darwin/arm.
67+
// Disable for now.
68+
const pushCallSupported = GOOS != "darwin"
6769

6870
func (c *sigctxt) pushCall(targetPC uintptr) {
6971
// Push the LR to stack, as we'll clobber it in order to

src/runtime/signal_arm64.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@ func (c *sigctxt) preparePanic(sig uint32, gp *g) {
7979
c.set_pc(uint64(funcPC(sigpanic)))
8080
}
8181

82-
const pushCallSupported = true
82+
// TODO(issue 35439): enabling async preemption causes failures on darwin/arm64.
83+
// Disable for now.
84+
const pushCallSupported = GOOS != "darwin"
8385

8486
func (c *sigctxt) pushCall(targetPC uintptr) {
8587
// Push the LR to stack, as we'll clobber it in order to

0 commit comments

Comments
 (0)