Skip to content

Commit 721f5ca

Browse files
tklausergopherbot
authored andcommitted
runtime: adjust comments for auxv getAuxv
github.com/cilium/ebpf no longer accesses getAuxv using linkname but now uses the golang.org/x/sys/unix.Auxv wrapper introduced in go.dev/cl/644295. Also adjust the list of users to include x/sys/unix. Updates #67839 Updates #67401 Change-Id: Ieee266360b22cc0bc4be8f740e0302afd7dbd14f Reviewed-on: https://go-review.googlesource.com/c/go/+/646535 Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Tobias Klauser <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent a7cbea8 commit 721f5ca

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

src/runtime/runtime.go

+4-12
Original file line numberDiff line numberDiff line change
@@ -290,23 +290,15 @@ func setCrashFD(fd uintptr) uintptr {
290290
}
291291

292292
// auxv is populated on relevant platforms but defined here for all platforms
293-
// so x/sys/cpu can assume the getAuxv symbol exists without keeping its list
294-
// of auxv-using GOOS build tags in sync.
293+
// so x/sys/cpu and x/sys/unix can assume the getAuxv symbol exists without
294+
// keeping its list of auxv-using GOOS build tags in sync.
295295
//
296296
// It contains an even number of elements, (tag, value) pairs.
297297
var auxv []uintptr
298298

299-
// golang.org/x/sys/cpu uses getAuxv via linkname.
299+
// golang.org/x/sys/cpu and golang.org/x/sys/unix use getAuxv via linkname.
300300
// Do not remove or change the type signature.
301-
// (See go.dev/issue/57336.)
302-
//
303-
// getAuxv should be an internal detail,
304-
// but widely used packages access it using linkname.
305-
// Notable members of the hall of shame include:
306-
// - github.com/cilium/ebpf
307-
//
308-
// Do not remove or change the type signature.
309-
// See go.dev/issue/67401.
301+
// See go.dev/issue/57336 and go.dev/issue/67401.
310302
//
311303
//go:linkname getAuxv
312304
func getAuxv() []uintptr { return auxv }

0 commit comments

Comments
 (0)