Skip to content

Commit 84808a2

Browse files
committed
os: disable symlink tests on android.
Creating symlinks (/data/local/tmp/*) doesn't seem to work on android-L (tested on nexus5). I cannot find any official documentation yet but just guess it's a measure for security attacks using symlinks. The tests failed with 'permission denied' errors. For #10807 Change-Id: I99a9c401c6ecca3c4adc7b21708adaf3dd601279 Reviewed-on: https://go-review.googlesource.com/16115 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 7628521 commit 84808a2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/os/os_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -672,7 +672,7 @@ func TestSymlink(t *testing.T) {
672672

673673
func TestLongSymlink(t *testing.T) {
674674
switch runtime.GOOS {
675-
case "plan9", "nacl":
675+
case "android", "plan9", "nacl":
676676
t.Skipf("skipping on %s", runtime.GOOS)
677677
case "windows":
678678
if !supportsSymlinks {

src/os/path_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ func TestRemoveAll(t *testing.T) {
170170

171171
func TestMkdirAllWithSymlink(t *testing.T) {
172172
switch runtime.GOOS {
173-
case "nacl", "plan9":
173+
case "android", "nacl", "plan9":
174174
t.Skipf("skipping on %s", runtime.GOOS)
175175
case "windows":
176176
if !supportsSymlinks {

0 commit comments

Comments
 (0)