Skip to content

Commit 84f9c42

Browse files
committed
os: skip TestRemoveAllRace on Windows
It's just fundamentally incompatible with Windows' pickiness about removing things that are in use. TBR=brainman CC=golang-codereviews https://golang.org/cl/142270043
1 parent e4fa1e4 commit 84f9c42

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/os/os_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1422,6 +1422,14 @@ func mkdirTree(t *testing.T, root string, level, max int) {
14221422
// Test that simultaneous RemoveAll do not report an error.
14231423
// As long as it gets removed, we should be happy.
14241424
func TestRemoveAllRace(t *testing.T) {
1425+
if runtime.GOOS == "windows" {
1426+
// Windows has very strict rules about things like
1427+
// removing directories while someone else has
1428+
// them open. The racing doesn't work out nicely
1429+
// like it does on Unix.
1430+
t.Skip("skipping on windows")
1431+
}
1432+
14251433
n := runtime.GOMAXPROCS(16)
14261434
defer runtime.GOMAXPROCS(n)
14271435
root, err := ioutil.TempDir("", "issue")

0 commit comments

Comments
 (0)