runtime: run gdb with a timeout for TestGdbBacktrace

aclements · aclements · commit 8692bacb6a43 · 2021-12-12T14:36:21.000Z
This sometimes times out and we don't have any useful output for debugging it. Hopefully this will help. For #37405. Change-Id: I79074e6fbb9bd16a864c651109a0acbfc8aa6cef Reviewed-on: https://go-review.googlesource.com/c/go/+/370703 Trust: Austin Clements <austin@google.com> Run-TryBot: Austin Clements <austin@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go
@@ -424,7 +424,7 @@ func TestGdbBacktrace(t *testing.T) {
 		"-ex", "continue",
 		filepath.Join(dir, "a.exe"),
 	}
-	got, err := exec.Command("gdb", args...).CombinedOutput()
+	got, err := testenv.RunWithTimeout(t, exec.Command("gdb", args...))
 	t.Logf("gdb output:\n%s", got)
 	if err != nil {
 		t.Fatalf("gdb exited with error: %v", err)

Original file line number	Diff line number	Diff line change
`@@ -424,7 +424,7 @@ func TestGdbBacktrace(t *testing.T) {`
`424`	`424`	`"-ex", "continue",`
`425`	`425`	`filepath.Join(dir, "a.exe"),`
`426`	`426`	`}`
`427`		`- got, err := exec.Command("gdb", args...).CombinedOutput()`
	`427`	`+ got, err := testenv.RunWithTimeout(t, exec.Command("gdb", args...))`
`428`	`428`	`t.Logf("gdb output:\n%s", got)`
`429`	`429`	`if err != nil {`
`430`	`430`	`t.Fatalf("gdb exited with error: %v", err)`