Skip to content

Commit b5b2cf5

Browse files
cuonglmrandall77
authored andcommitted
go/types,types2: exclude tests that need cgo.Incomplete
Since when go/types,types2 do not know about build constraints, and runtime/cgo.Incomplete is only available on platforms that support cgo. These tests are also failing on aix with failure from linker, so disable them on aix to make builder green. The fix for aix is tracked in #54814 Updates #46731 Updates #54814 Change-Id: I5d6f6e29a8196efc6c457ea64525350fc6b20309 Reviewed-on: https://go-review.googlesource.com/c/go/+/427394 Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Auto-Submit: Cuong Manh Le <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Cuong Manh Le <[email protected]>
1 parent 91ef076 commit b5b2cf5

File tree

8 files changed

+24
-7
lines changed

8 files changed

+24
-7
lines changed

Diff for: src/cmd/compile/internal/types2/stdlib_test.go

+9
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,15 @@ func TestStdFixed(t *testing.T) {
197197
"issue48230.go", // go/types doesn't check validity of //go:xxx directives
198198
"issue49767.go", // go/types does not have constraints on channel element size
199199
"issue49814.go", // go/types does not have constraints on array size
200+
201+
// These tests requires runtime/cgo.Incomplete, which is only available on some platforms.
202+
// However, types2 does not know about build constraints.
203+
"bug514.go",
204+
"issue40954.go",
205+
"issue42032.go",
206+
"issue42076.go",
207+
"issue46903.go",
208+
"issue51733.go",
200209
)
201210
}
202211

Diff for: src/go/types/stdlib_test.go

+9
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,15 @@ func TestStdFixed(t *testing.T) {
199199
"issue48230.go", // go/types doesn't check validity of //go:xxx directives
200200
"issue49767.go", // go/types does not have constraints on channel element size
201201
"issue49814.go", // go/types does not have constraints on array size
202+
203+
// These tests requires runtime/cgo.Incomplete, which is only available on some platforms.
204+
// However, go/types does not know about build constraints.
205+
"bug514.go",
206+
"issue40954.go",
207+
"issue42032.go",
208+
"issue42076.go",
209+
"issue46903.go",
210+
"issue51733.go",
202211
)
203212
}
204213

Diff for: test/fixedbugs/bug514.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// Use of this source code is governed by a BSD-style
55
// license that can be found in the LICENSE file.
66

7-
//go:build cgo
7+
//go:build cgo && !aix
88

99
package main
1010

Diff for: test/fixedbugs/issue40954.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// Use of this source code is governed by a BSD-style
55
// license that can be found in the LICENSE file.
66

7-
//go:build cgo
7+
//go:build cgo && !aix
88

99
package main
1010

Diff for: test/fixedbugs/issue42032.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// source code is governed by a BSD-style license that can be found in
55
// the LICENSE file.
66

7-
//go:build cgo
7+
//go:build cgo && !aix
88

99
package main
1010

Diff for: test/fixedbugs/issue42076.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// source code is governed by a BSD-style license that can be found in
55
// the LICENSE file.
66

7-
//go:build cgo
7+
//go:build cgo && !aix
88

99
package main
1010

Diff for: test/fixedbugs/issue46903.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// run
2-
//go:build goexperiment.unified && cgo
3-
// +build goexperiment.unified,cgo
2+
//go:build goexperiment.unified && cgo && !aix
43

54
// TODO(mdempsky): Enable test unconditionally. This test should pass
65
// for non-unified mode too.

Diff for: test/fixedbugs/issue51733.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// Use of this source code is governed by a BSD-style
55
// license that can be found in the LICENSE file.
66

7-
//go:build cgo
7+
//go:build cgo && !aix
88

99
package main
1010

0 commit comments

Comments
 (0)