Skip to content

Commit c7f870e

Browse files
Bryan C. Millsgopherbot
Bryan C. Mills
authored andcommitted
cmd/go: skip test cases that depend on gopkg.in
Updates #54503. Change-Id: Ie13d028b09260d2d316c343b3ea812bb9cce4e6d Reviewed-on: https://go-review.googlesource.com/c/go/+/424594 Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Bryan Mills <[email protected]> Reviewed-by: Russ Cox <[email protected]>
1 parent 57d0551 commit c7f870e

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/cmd/go/internal/modfetch/coderepo_test.go

+9-1
Original file line numberDiff line numberDiff line change
@@ -578,6 +578,10 @@ func TestCodeRepo(t *testing.T) {
578578
for _, tt := range codeRepoTests {
579579
f := func(tt codeRepoTest) func(t *testing.T) {
580580
return func(t *testing.T) {
581+
if strings.Contains(tt.path, "gopkg.in") {
582+
testenv.SkipFlaky(t, 54503)
583+
}
584+
581585
t.Parallel()
582586
if tt.vcs != "mod" {
583587
testenv.MustHaveExecPath(t, tt.vcs)
@@ -811,8 +815,12 @@ func TestCodeRepoVersions(t *testing.T) {
811815

812816
t.Run("parallel", func(t *testing.T) {
813817
for _, tt := range codeRepoVersionsTests {
818+
tt := tt
814819
t.Run(strings.ReplaceAll(tt.path, "/", "_"), func(t *testing.T) {
815-
tt := tt
820+
if strings.Contains(tt.path, "gopkg.in") {
821+
testenv.SkipFlaky(t, 54503)
822+
}
823+
816824
t.Parallel()
817825
if tt.vcs != "mod" {
818826
testenv.MustHaveExecPath(t, tt.vcs)

src/cmd/go/testdata/script/mod_gopkg_unstable.txt

+2
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ go list
1010
[!net] skip
1111
[!exec:git] skip
1212

13+
skip # TODO(#54503): redirect gopkg.in requests to a local server and re-enable.
14+
1315
env GOPROXY=direct
1416
env GOSUMDB=off
1517
go get gopkg.in/macaroon-bakery.v2-unstable/bakery

0 commit comments

Comments
 (0)