Skip to content

Commit f6c624a

Browse files
benshi001bradfitz
authored andcommitted
cmd/internal/obj/arm: remove NaCl related DATABUNDLE
Updates #30439 Change-Id: Ieaf18b7cfd22a768eb1b7ac549ebc03637258876 Reviewed-on: https://go-review.googlesource.com/c/go/+/201377 Run-TryBot: Ben Shi <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Keith Randall <[email protected]>
1 parent 03bb3e9 commit f6c624a

File tree

3 files changed

+4
-21
lines changed

3 files changed

+4
-21
lines changed

Diff for: src/cmd/internal/obj/arm/a.out.go

-3
Original file line numberDiff line numberDiff line change
@@ -362,9 +362,6 @@ const (
362362
AMULAWB
363363
AMULABB
364364

365-
ADATABUNDLE
366-
ADATABUNDLEEND
367-
368365
AMRC // MRC/MCR
369366

370367
ALAST

Diff for: src/cmd/internal/obj/arm/anames.go

-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: src/cmd/internal/obj/arm/asm5.go

+4-16
Original file line numberDiff line numberDiff line change
@@ -329,8 +329,6 @@ var optab = []Optab{
329329
{obj.ANOP, C_NONE, C_NONE, C_NONE, 0, 0, 0, 0, 0, 0},
330330
{obj.ADUFFZERO, C_NONE, C_NONE, C_SBRA, 5, 4, 0, 0, 0, 0}, // same as ABL
331331
{obj.ADUFFCOPY, C_NONE, C_NONE, C_SBRA, 5, 4, 0, 0, 0, 0}, // same as ABL
332-
{ADATABUNDLE, C_NONE, C_NONE, C_NONE, 100, 4, 0, 0, 0, 0},
333-
{ADATABUNDLEEND, C_NONE, C_NONE, C_NONE, 100, 0, 0, 0, 0, 0},
334332
{obj.AXXX, C_NONE, C_NONE, C_NONE, 0, 4, 0, 0, 0, 0},
335333
}
336334

@@ -434,7 +432,7 @@ func span5(ctxt *obj.Link, cursym *obj.LSym, newprog obj.ProgAlloc) {
434432
}
435433
}
436434

437-
if m == 0 && (p.As != obj.AFUNCDATA && p.As != obj.APCDATA && p.As != ADATABUNDLEEND && p.As != obj.ANOP) {
435+
if m == 0 && (p.As != obj.AFUNCDATA && p.As != obj.APCDATA && p.As != obj.ANOP) {
438436
ctxt.Diag("zero-width instruction\n%v", p)
439437
continue
440438
}
@@ -522,7 +520,7 @@ func span5(ctxt *obj.Link, cursym *obj.LSym, newprog obj.ProgAlloc) {
522520
if m/4 > len(out) {
523521
ctxt.Diag("instruction size too large: %d > %d", m/4, len(out))
524522
}
525-
if m == 0 && (p.As != obj.AFUNCDATA && p.As != obj.APCDATA && p.As != ADATABUNDLEEND && p.As != obj.ANOP) {
523+
if m == 0 && (p.As != obj.AFUNCDATA && p.As != obj.APCDATA && p.As != obj.ANOP) {
526524
if p.As == obj.ATEXT {
527525
c.autosize = p.To.Offset + 4
528526
continue
@@ -615,7 +613,6 @@ func span5(ctxt *obj.Link, cursym *obj.LSym, newprog obj.ProgAlloc) {
615613
func (c *ctxt5) checkpool(p *obj.Prog, nextpc int32) bool {
616614
poolLast := nextpc
617615
poolLast += 4 // the AB instruction to jump around the pool
618-
poolLast += 12 // the maximum nacl alignment padding for ADATABUNDLE
619616
poolLast += int32(c.pool.size) - 4 // the offset of the last pool entry
620617

621618
refPC := int32(c.pool.start) // PC of the first pool reference
@@ -643,7 +640,7 @@ func (c *ctxt5) flushpool(p *obj.Prog, skip int, force int) bool {
643640
q.Link = c.blitrl
644641
q.Pos = p.Pos
645642
c.blitrl = q
646-
} else if force == 0 && (p.Pc+int64(12+c.pool.size)-int64(c.pool.start) < 2048) { // 12 take into account the maximum nacl literal pool alignment padding size
643+
} else if force == 0 && (p.Pc+int64(c.pool.size)-int64(c.pool.start) < 2048) {
647644
return false
648645
}
649646

@@ -1424,9 +1421,7 @@ func buildop(ctxt *obj.Link) {
14241421
obj.AUNDEF,
14251422
obj.AFUNCDATA,
14261423
obj.APCDATA,
1427-
obj.ANOP,
1428-
ADATABUNDLE,
1429-
ADATABUNDLEEND:
1424+
obj.ANOP:
14301425
break
14311426
}
14321427
}
@@ -2481,13 +2476,6 @@ func (c *ctxt5) asmout(p *obj.Prog, o *Optab, out []uint32) {
24812476
o1 |= (uint32(p.Reg) & 15) << 0
24822477
o1 |= uint32((p.To.Offset & 15) << 12)
24832478

2484-
// DATABUNDLE: BKPT $0x5be0, signify the start of NaCl data bundle;
2485-
// DATABUNDLEEND: zero width alignment marker
2486-
case 100:
2487-
if p.As == ADATABUNDLE {
2488-
o1 = 0xe125be70
2489-
}
2490-
24912479
case 105: /* divhw r,[r,]r */
24922480
o1 = c.oprrr(p, p.As, int(p.Scond))
24932481
rf := int(p.From.Reg)

0 commit comments

Comments
 (0)