-
Notifications
You must be signed in to change notification settings - Fork 18k
proposal: cmd/go: Allow tarball-over-http downloads in <meta name="go-import"> #16545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
#11876 is the same one, that had been rejected. |
I think that other thread was rejected because (A) lack of other community interest, and (B) no clear path to support But today Go is more popular, i am interested. And |
Removing the package directory is unsafe because the user might have edited the code it contains. |
For the specific case of a git backend, local modifications seem to be preserved. But i don't think this behavior is contractual. There's no mention of it in https://golang.org/cmd/go/#hdr-Download_and_install_packages_and_dependencies , only to "use the network to update the named packages and their dependencies". I see some possible options:
So How about 1 or 2 above? |
From the above, number two seems the least invasive, however that's not what
If we want this at all, then I suggest just returning an error and failing early, such as when there are local modifications for a versioned package. People will need to remove the package directory to continue with a |
Sorry, I think we're going to decline this proposal. The Go project isn't interested in building a version control system and once we start thinking through all the implications of implementing this proposal, it starts to sound like a version control system. Since Github and other version control system hosting providers are free, and Go already has a mechanism to point at an existing VCS from your HTML file on your own domain, we recommend you just use Github + |
Feature request
I would like for
go get
to support downloading tarballs, in addition to the current git/hg/svn/bzr support.Since the argument to
go get
is a package name, this should be implemented as an extra backend to the currentgo-import
meta tag /?go-get=1
system as described in https://golang.org/cmd/go/#hdr-Remote_import_paths .Rationale
go get
-able packages on object storage servers.go get
-able packages on low-end servers.Implementation
I think it should be possible to implement initially in
src/cmd/go/vcs.go
as a newvcsCmd
type that shells out to external wget/curl and tar binaries, in much the same way as the existing code.This proposal succeeds #14076 .
Do you think this would be accepted by the Go project? If so, I am happy to develop and submit a patch with a goal of having this in Go 1.8.
The text was updated successfully, but these errors were encountered: