x/tools/godoc: TestCommandLine failed

[hirochachacha]

Please answer these questions before submitting your issue. Thanks!

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

do go test golang.org/x/tools/godoc

What did you expect to see?

success.

What did you see instead?

--- FAIL: TestCommandLine (0.01s)
	cmdline_test.go:290: root directory: CommandLine([/]) = "COMMAND " (<nil>); want "" (false)
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
2017/12/20 20:37:12 updateMetadata: file does not exist
FAIL
FAIL	golang.org/x/tools/godoc	0.309s

Does this issue reproduce with the latest release (go1.9.2)?

I think so.

System details

go version devel +3aeb3950a9 Mon Dec 18 20:24:12 2017 +0000 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/hiro/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/hiro/.go"
GORACE=""
GOROOT="/Users/hiro/go"
GOTMPDIR=""
GOTOOLDIR="/Users/hiro/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/wq/dwn8hs0x7njbzty9f68y61700000gn/T/go-build668389539=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version devel +3aeb3950a9 Mon Dec 18 20:24:12 2017 +0000 darwin/amd64
GOROOT/bin/go tool compile -V: compile version devel +3aeb3950a9 Mon Dec 18 20:24:12 2017 +0000
uname -v: Darwin Kernel Version 17.3.0: Thu Nov  9 18:09:22 PST 2017; root:xnu-4570.31.3~1/RELEASE_X86_64
ProductName:	Mac OS X
ProductVersion:	10.13.2
BuildVersion:	17C88
lldb --version: lldb-900.0.64
  Swift-4.0
gdb --version: GNU gdb (GDB) 8.0.1

[bradfitz]

What version of x/tools do you have?

[hirochachacha]

What version of x/tools do you have?

tip.

FWIW, If I remove the last case,

diff --git a/godoc/cmdline_test.go b/godoc/cmdline_test.go
index 602f2bba..6427eb07 100644
--- a/godoc/cmdline_test.go
+++ b/godoc/cmdline_test.go
@@ -278,11 +278,11 @@ package main
                        args: []string{"vet"},
                        exp:  "use 'godoc cmd/vet' for documentation on the vet command \n\nPACKAGE Package vet\n",
                },
-               {
-                       desc: "root directory",
-                       args: []string{"/"},
-                       exp:  "",
-               },
+               // {
+               // desc: "root directory",
+               // args: []string{"/"},
+               // exp:  "",
+               // },
        } {
                w := new(bytes.Buffer)
                err := CommandLine(w, fs, p, tc.args)

$ go test golang.org/x/tools/godoc
ok  	golang.org/x/tools/godoc	0.272s

Also,

$ cd $GOPATH/src/golang.org/x/tools/godoc
$ go test
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
2017/12/21 07:34:36 updateMetadata: file does not exist
PASS
ok  	golang.org/x/tools/godoc	0.291s

I'm puzzled.

[hirochachacha]

OK, in general, go test xxx doesn't show stdout and stderr if it succeed.
go test show stdout and stderr even if it succeed.

[ysmolski]

I cannot reproduce this on go version devel +2767c4e285 Fri Mar 16 21:01:28 2018 +0000 darwin/amd64 and x/tools tip: 22265336.

@hirochachacha can you still reproduce this?

[hirochachacha]

I could not reproduce this any more.
I've tested go1.9.4, go1.10 and tip.
Closing. Thank you for your comment.