Skip to content

x/oauth2: clarify which context key is used #27607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamdecaf opened this issue Sep 10, 2018 · 2 comments
Closed

x/oauth2: clarify which context key is used #27607

adamdecaf opened this issue Sep 10, 2018 · 2 comments

Comments

@adamdecaf
Copy link
Contributor

What did you do?

The current documentation states:

// The HTTP client to use is derived from the context.
// If a client is not provided via the context, http.DefaultClient is used.

What did you expect to see?

There's no clear indication how one is to alter the Context in order to mutate that client (i.e. setting timeouts). We know that the default timeouts are bad (#24138) and so modifying those is important to do.

@gopherbot gopherbot added this to the Unreleased milestone Sep 10, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/134436 mentions this issue: doc: clarify context key used

@adamdecaf
Copy link
Contributor Author

Whoops. I'll use golang/oauth2#321 instead.

@golang golang locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants