Skip to content

cmd/go: factor out internal/semver, internal/modfile etc #28101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rogpeppe opened this issue Oct 9, 2018 · 2 comments
Closed

cmd/go: factor out internal/semver, internal/modfile etc #28101

rogpeppe opened this issue Oct 9, 2018 · 2 comments
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.13

Comments

@rogpeppe
Copy link
Contributor

rogpeppe commented Oct 9, 2018

The parsing functionality found in the modfile package is useful to external tools
(for example for tools that wish to edit go.mod files in ways not supported by go mod edit, such as gohack).

The semver functionality found in semver is not quite the same as other semver packages, and is likewise useful for external packages.

There are already at least two repositories containing copies of these packages 1 2. It would be nice if there was a commonly recognized place for them.
@myitcv
Copy link
Member

myitcv commented Oct 9, 2018

cc @bcmills

@bcmills bcmills added GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 9, 2018
@bcmills bcmills added this to the Go1.12 milestone Oct 9, 2018
@bcmills bcmills added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Oct 9, 2018
@bcmills bcmills modified the milestones: Go1.12, Go1.13 Nov 15, 2018
@thepudds thepudds mentioned this issue Feb 10, 2019
Closed
@bcmills bcmills mentioned this issue Feb 12, 2019
Closed
@davidovich davidovich mentioned this issue Feb 28, 2019
Merged
@jayconrod jayconrod mentioned this issue Mar 27, 2019
Closed
@rsc rsc changed the title cmd/go/internal/{modfile, semver}: factor out of internal cmd/go/: factor out internal/semver, internal/modfile etc Apr 23, 2019
@rsc rsc changed the title cmd/go/: factor out internal/semver, internal/modfile etc cmd/go: factor out internal/semver, internal/modfile etc Apr 23, 2019
@jayconrod jayconrod mentioned this issue Apr 24, 2019
Closed
@bcmills bcmills mentioned this issue Apr 30, 2019
Closed
13 tasks
@rsc
Copy link
Contributor

rsc commented Apr 30, 2019

Closing as duplicate of #31761 (assuming something like that is accepted and implemented).

@mvdan mvdan closed this as completed May 1, 2019
@myitcv myitcv mentioned this issue Jun 29, 2019
Closed
@golang golang locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge GoCommand cmd/go modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
6 participants
@rogpeppe @rsc @myitcv @mvdan @bcmills @gopherbot