x/tools/go/internal/gcimporter: frequent failures with SIGSEGV on openbsd-386-64 builder #36563

dmitshur · 2020-01-15T00:52:14Z

From build.golang.org, the tests for this package fail on openbsd-386-64 builder:

haserrors/haserrors.go:2:22: cannot convert "" (untyped string constant) to untyped int
haserrors/haserrors.go:3:18: undeclared name: undefined
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8f2b000 pc=0x8049ef8]

runtime stack:
runtime/internal/atomic.Xadd64(0x847af80, 0x7d4, 0x0, 0x4bd8c8c, 0x0)
	/tmp/workdir/go/src/runtime/internal/atomic/asm_386.s:125 +0x28

goroutine 35 [GC worker (idle)]:
runtime.systemstack_switch()
	/tmp/workdir/go/src/runtime/asm_386.s:357 fp=0x3c48579c sp=0x3c485798 pc=0x80963c0
runtime.gcBgMarkWorker(0x3c01f900)
	/tmp/workdir/go/src/runtime/mgc.go:1890 +0x1a0 fp=0x3c4857e8 sp=0x3c48579c pc=0x805f5f0
runtime.goexit()
	/tmp/workdir/go/src/runtime/asm_386.s:1321 +0x1 fp=0x3c4857ec sp=0x3c4857e8 pc=0x8097b41
created by runtime.gcBgMarkStartWorkers
	/tmp/workdir/go/src/runtime/mgc.go:1784 +0x5b

goroutine 1 [chan receive]:
testing.(*T).Run(0x61f91f40, 0x82919be, 0x16, 0x829c004, 0x1)
	/tmp/workdir/go/src/testing/testing.go:917 +0x2ce
testing.runTests.func1(0x3c0761e0)
[...]
	/tmp/workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:970 +0x23
created by golang.org/x/tools/go/loader.(*importer).startLoad
	/tmp/workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:969 +0x145

goroutine 3198 [chan receive]:
golang.org/x/tools/go/loader.(*importInfo).awaitCompletion(...)
	/tmp/workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:447
golang.org/x/tools/go/loader.(*importer).importAll(0x4324c2d0, 0x60e29d41, 0x10, 0x58cdbdd0, 0x24, 0x4e328b00, 0x0, 0x2, 0x5ab82620, 0x5ab82600, ...)
	/tmp/workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:921 +0x2ed
golang.org/x/tools/go/loader.(*importer).addFiles(0x4324c2d0, 0x61b3ccc0, 0x43c04138, 0x2, 0x2, 0x1)
	/tmp/workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:1014 +0x8e
golang.org/x/tools/go/loader.(*importer).load(0x4324c2d0, 0x5a20bd40, 0x4d8ff218)
	/tmp/workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:989 +0xf9
golang.org/x/tools/go/loader.(*importer).startLoad.func1(0x4324c2d0, 0x5a20bd40, 0x5b056950)
	/tmp/workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:970 +0x23
created by golang.org/x/tools/go/loader.(*importer).startLoad
	/tmp/workdir/gopath/src/golang.org/x/tools/go/loader/loader.go:969 +0x145
FAIL	golang.org/x/tools/go/internal/gcimporter	58.215s

(Source: https://build.golang.org/log/bf78c570cc6e1acb6dbc4391d770300022c9b6be)

Recent occurrences from https://build.golang.org/?repo=golang.org%2fx%2ftools:

I suspect this may be similar to #36444. This builder is currently on n1-highcpu-4, which has only 3.6 GB memory, and that is likely not enough for x/tools tests to pass.

/cc @stamblerre @matloob

The text was updated successfully, but these errors were encountered:

bcmills · 2021-10-04T18:53:14Z

greplogs --dashboard -md -l -e '(?ms)unexpected signal during runtime execution.*FAIL\s+golang\.org/x/tools/go/internal/gcimporter'

bcmills · 2021-10-04T18:54:30Z

This builder is currently on n1-highcpu-4, which has only 3.6 GB memory, and that is likely not enough for x/tools tests to pass.

If that is the case, the fact that this is reported as unexpected signal during runtime execution rather than something clearer seems like a bug in the runtime.

bcmills · 2021-10-04T18:56:21Z

This test seems to be failing around 50% of runs on this particular builder. That makes it a release-blocker for Go 1.18 via #11811.

Since this is not a first-class port, we can resolve it by fixing the underlying issue, adding or adjusting test skips, or skipping all of x/tools for this builder.

toothrot · 2021-10-13T16:17:02Z

Friendly ping that this is a release-blocking issue for Go 1.18.

dmitshur · 2021-10-13T16:43:12Z

From the original comment:

I suspect this may be similar to #36444. This builder is currently on n1-highcpu-4, which has only 3.6 GB memory, and that is likely not enough for x/tools tests to pass.

By now, I am even more confident that builders testing x/tools should have around 16~ GB RAM (see #33986). Many of the builders have been modified to have that much, so I think we should do the same here as the next step.

dmitshur · 2021-10-13T16:59:14Z

Now that CL 354757 is submitted, I'll send a CL for this.

gopherbot · 2021-10-13T17:50:21Z

Change https://golang.org/cl/355669 mentions this issue: dashboard: upsize openbsd-386-64 to 16 GB RAM

dmitshur · 2021-10-13T18:02:09Z

I'll give it some time before submitting CL 355669, since the builder machine type changed slightly in CL 354757, so we have more data. (Otherwise we won't know what it was that fixed it.)

This builder is currently on n1-highcpu-4, which has only 3.6 GB memory, and that is likely not enough for x/tools tests to pass.

If that is the case, the fact that this is reported as unexpected signal during runtime execution rather than something clearer seems like a bug in the runtime.

If we confirm this was indeed due to insufficient memory, we should make a separate issue for the runtime package.

gopherbot · 2021-10-20T17:28:03Z

Change https://golang.org/cl/357370 mentions this issue: dashboard: remove OpenBSD 6.4 builders

dmitshur · 2021-10-20T17:31:36Z

This is a 32-bit architecture, so increasing RAM of the machine to 16 GB probably won't help (thanks @cagedmantis for catching this).

I think the right next step here is #49090.

dmitshur added OS-OpenBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 15, 2020

gopherbot added this to the Unreleased milestone Jan 15, 2020

gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 15, 2020

dmitshur changed the title ~~x/tools/go/internal/gcimporter: test fails on openbsd-386-64 builder on release-branch.go1.12~~ x/tools/go/internal/gcimporter: test fails on openbsd-386-64 builder Jan 15, 2020

bcmills mentioned this issue May 10, 2021

runtime: SIGSEGV in mmap_trampoline on openbsd-386-64 builder #46080

Closed

findleyr mentioned this issue May 25, 2021

x/tools/go/internal/gcimporter: frequent failures without useful output #38415

Closed

bcmills added the release-blocker label Oct 4, 2021

bcmills modified the milestones: Unreleased, Go1.18 Oct 4, 2021

bcmills changed the title ~~x/tools/go/internal/gcimporter: test fails on openbsd-386-64 builder~~ x/tools/go/internal/gcimporter: frequent failures with SIGSEGV on openbsd-386-64 builder Oct 4, 2021

gopherbot closed this as completed in golang/build@beddf46 Oct 20, 2021

golang locked and limited conversation to collaborators Oct 20, 2022

gopherbot added the FrozenDueToAge label Oct 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/go/internal/gcimporter: frequent failures with SIGSEGV on openbsd-386-64 builder #36563

x/tools/go/internal/gcimporter: frequent failures with SIGSEGV on openbsd-386-64 builder #36563

dmitshur commented Jan 15, 2020

bcmills commented Oct 4, 2021

bcmills commented Oct 4, 2021

bcmills commented Oct 4, 2021

toothrot commented Oct 13, 2021

dmitshur commented Oct 13, 2021

dmitshur commented Oct 13, 2021

gopherbot commented Oct 13, 2021

dmitshur commented Oct 13, 2021

gopherbot commented Oct 20, 2021

dmitshur commented Oct 20, 2021

x/tools/go/internal/gcimporter: frequent failures with SIGSEGV on openbsd-386-64 builder #36563

x/tools/go/internal/gcimporter: frequent failures with SIGSEGV on openbsd-386-64 builder #36563

Comments

dmitshur commented Jan 15, 2020

bcmills commented Oct 4, 2021

bcmills commented Oct 4, 2021

bcmills commented Oct 4, 2021

toothrot commented Oct 13, 2021

dmitshur commented Oct 13, 2021

dmitshur commented Oct 13, 2021

gopherbot commented Oct 13, 2021

dmitshur commented Oct 13, 2021

gopherbot commented Oct 20, 2021

dmitshur commented Oct 20, 2021